397373 - Make &state=disabled work again

Status: RESOLVED FIXED

(Core :: Graphics: ImageLib, defect)

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.3) Gecko/20061201 Firefox/2.0.0.3 (Ubuntu-feisty)

For perfect OS integration on Linux/GNOME it would be very nice if we could create a theme that always picks up the icons from the GTK icon theme.

This is possible today, by using moz-icon://stock/*. The only problem so far is that I am unable to create the disabled state of buttons, because there is no way to display a button in grayscale and XUL doesn't seem to do this itself (when the button is "disabled").

Now, creating separate icons for disabled stats would be possible, but it also defeats the whole purpose of this. So, would it be possible to provide a "-moz-disabled" property, similar to -moz-opacity, which draws the icon with less saturation to make it look gray/disabled?

Reproducible: Always

Comment 1

[Michael Ventnor]

Just add &state=disabled to the end of the icon URL, but it is broken at the moment. This is actually because of a typo I found in the code  a little while ago, I have a patch for it coming up.

Comment 2

[Michael Ventnor]

Attachment: Patch

Simple typo, trivial patch, we're only human.

Comment 3

[Reed Loden [:reed]]

Checking in modules/libpr0n/decoders/icon/nsIconURI.cpp;
/cvsroot/mozilla/modules/libpr0n/decoders/icon/nsIconURI.cpp,v  <--  nsIconURI.cpp
new revision: 1.28; previous revision: 1.27
done