Closed Bug 397412 Opened 17 years ago Closed 17 years ago

Starting Venkman with -venkman on the commandline hides statusbar

Categories

(Other Applications Graveyard :: Venkman JS Debugger, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mnyromyr, Assigned: rginda)

Details

Attachments

(1 file)

When starting Venkman from the (SM or TB) commandline with -venkman, the statusbar is missing. It's there if you open Venkman from SM's Tools menu.
Attachment #282174 - Flags: review?(gijskruitbosch+bugs)
Comment on attachment 282174 [details] [diff] [review]
show statusbar by default, hide component-bar for non-Mojiri

>     if (console.host == "Firefox") {
>         tasksMenu.parentNode.removeChild(tasksMenu);
>         winMenu.parentNode.removeChild(winMenu);
>-    } else {
>-        comBar.collapsed = false;
>+        comBar.collapsed = true;
>     }

This hides the component bar on suite and friends. Why?
> >     if (console.host == "Firefox") {
> >         tasksMenu.parentNode.removeChild(tasksMenu);
> >         winMenu.parentNode.removeChild(winMenu);
> >-    } else {
> >-        comBar.collapsed = false;
> >+        comBar.collapsed = true;
> >     }
> 
> This hides the component bar on suite and friends.

No. The componentbar is visible by default if the statusbar is shown, and this code hides it for Firefox and co...




(JFTR, if anyone else is wondering: the view-manager.js portion of this diff does not belong to this patch and is already checked in anyway.)
(In reply to comment #2)
> > >     if (console.host == "Firefox") {
> > >         tasksMenu.parentNode.removeChild(tasksMenu);
> > >         winMenu.parentNode.removeChild(winMenu);
> > >-    } else {
> > >-        comBar.collapsed = false;
> > >+        comBar.collapsed = true;
> > >     }
> > 
> > This hides the component bar on suite and friends.
> 
> No. The componentbar is visible by default if the statusbar is shown, and this
> code hides it for Firefox and co...

OK, so I need to be more awake when trying to read this. Sorry.

Either way, that makes me wonder - if starting venkman from Tools > JS Debugger doesn't show it on Firefox already, and did on Suite, why do you need this change?
When I patch only openDebuggerWindow and start eg. TB with -venkman, I'll get a statusbar with an empty componentbar, which isn't nice.
Comment on attachment 282174 [details] [diff] [review]
show statusbar by default, hide component-bar for non-Mojiri

Those console.host things are not sane. Will file a followup bug. You get r+ for this though :-)
Attachment #282174 - Flags: review?(gijskruitbosch+bugs) → review+
Landed the first two hunks on trunk (see end of comment #2).
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Other Applications → Other Applications Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: