397711 - Typo in MMgc/WriteBarrier.h

Status: VERIFIED FIXED

(Tamarin Graveyard :: Garbage Collection (mmGC), defect)

Description

[Jason Orendorff [:jorendorff]]

Attachment: v1

The || here should be &&, right?

		T set(const T tNew)
		{
			if(t != tNew || tNew != 0)
				GC::WriteBarrier(this, (const void*)tNew);
			else
				t = tNew;
			return tNew;
		}

The typo doesn't cause any problems, but it looks like this code doesn't prevent the call to GC::WriteBarrier as often as it's intended to.

Comment 1

[Edwin Smith]

Comment on attachment 282474 [details] [diff] [review]
v1

looks fine, plus, if t == tNew then the WB could be a no-op.  not sure if the extra branching is worth it.

Comment 2

[Jason Orendorff [:jorendorff]]

Pushed changeset d65a6b20f353 to tamarin-central.