Closed Bug 398184 Opened 17 years ago Closed 17 years ago

rebuild search bar dropdown onpopupshowing, not at startup

Categories

(Firefox :: Search, defect)

Product:
Firefox
Component:
Search
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 3 beta1

People

(Reporter: Gavin, Assigned: Gavin)

Details

(Keywords: perf)

Attachments

(1 file, 2 obsolete files)

with that change
2.88 KB, patch
mconnor
: approval1.9+
Details | Diff | Splinter Review
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED

        Attachment #283048 -
        Flags: review?

        Attachment #283048 -
        Flags: review? → review?(mconnor)

    
    

    
  
Comment on attachment 283048 [details] [diff] [review]
patch

this seems wrong... :)

        Attachment #283048 -
        Flags: review?(mconnor) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        better patch (obsolete)
        — 
          — Splinter Review
      

    


  

        Attachment #283057 -
        Flags: review?

        Attachment #283048 -
        Attachment is obsolete: true

        Attachment #283057 -
        Flags: review? → review?(mconnor)

    
    

    
  
The previous patch made us rebuild the popup for each popupshowing. This new one only rebuilds the popup on the first popupshowing, or when things have changed.

    
    

    
  
Comment on attachment 283057 [details] [diff] [review]
better patch

Hmm.  How about we remove the check from rebuildPopup, and check _needToRebuildPopup in rebuildPopupDynamic and then call rebuildPopup from there?  saves one function call on every popupshowing, and avoids having to set it from every caller

        Attachment #283057 -
        Flags: review?(mconnor) → review+

    
  

        Attachment #283057 -
        Flags: approval1.9?

    
    

    
  

      
      
      
      

        Attached patch
          
          
        with that change
        — 
          — Splinter Review
      

    


  

        Attachment #283057 -
        Attachment is obsolete: true

        Attachment #283071 -
        Flags: approval1.9?

        Attachment #283057 -
        Flags: approval1.9?

        Attachment #283071 -
        Flags: approval1.9? → approval1.9+

    
    

    
  
mozilla/browser/components/search/content/search.xml 	1.104
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 M9
Keywords: perf

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: