398375 - InterfaceAdapter and java.lang.Object methods

Status: RESOLVED INACTIVE

(Rhino Graveyard :: Core, enhancement)

Description

[Christophe Grand]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; fr; rv:1.8.1.7) Gecko/20070914 Firefox/2.0.0.7
Build Identifier: 1_7R1pre

When passing a function as an interface a proxy is created which not only delegates interface methods calls to the function but also calls to methods defined in java.lang.Object.
It follows that those proxies can't be used in a HashMap or a HashSet (hashCode and equals going through the js function).

(Calls can be discriminated by using arguments[arguments.length - 1] which contains the method name but it's awkward and seems to violate the constraint that all methods must have the same signatures.)


Reproducible: Always

Steps to Reproduce:
package bug;
public class Foo {
  Set d = new HashSet();
  public add(Callable c) {
    s.add(c);
  }
}
-------------
var f = new Packages.bug.Foo();
f.add(new function() { return true; });
Actual Results:  
Exception while trying to convert true into an int (hashCode return type).

Expected Results:  
The proxy being added to the set.

Comment 1

[Christophe Grand]

Attachment: Proposed patch.

Delegate only interfaces methods to the js function, use identity for "equals", delegate other methods to the target (java) object.

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Closing. Bug management is now done here:
https://github.com/mozilla/rhino