Closed Bug 398624 Opened 17 years ago Closed 17 years ago

PRBool misuse bugs in extensions/pref/

Categories

(Core :: Preferences: Backend, defect)

Product:
Core
Component:
Preferences: Backend
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9beta1

People

(Reporter: taras.mozilla, Assigned: taras.mozilla)

References

Details

Attachments

(1 file)

Prbool correction
2.02 KB, patch
Bienvenu
: review+
sayrer
: approval1.9+
Details | Diff | Splinter Review 
This was found by prcheck. This is my favourite bug so far. Turned out the function definition didn't match the declaration and some callers called it as it was specified in the definition and some in the declaration.
Attachment #283628 - Flags: review?(bienvenu)
Comment on attachment 283628 [details] [diff] [review]
Prbool correction

Thx for the patch. The other callers (the ones that were wrong) were OK because they passed 0 for both. So if I'm reading this correctly, there's no actual runtime bug, just code that looked wrong...
Attachment #283628 - Flags: review?(bienvenu) → review+
Attachment #283628 - Flags: approval1.9?
Attachment #283628 - Flags: approval1.9? → approval1.9+
Checking in extensions/pref/autoconfig/src/nsReadConfig.cpp;
/cvsroot/mozilla/extensions/pref/autoconfig/src/nsReadConfig.cpp,v  <--  nsReadConfig.cpp
new revision: 1.19; previous revision: 1.18
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Backed out as part of the fun-lovin' Tp-regression-finding game!
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Keywords: checkin-needed
Relanded.

Checking in extensions/pref/autoconfig/src/nsReadConfig.cpp;
/cvsroot/mozilla/extensions/pref/autoconfig/src/nsReadConfig.cpp,v  <--  nsReadConfig.cpp
new revision: 1.21; previous revision: 1.20
done
Status: REOPENED → RESOLVED
Closed: 17 years ago → 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M9
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: