398803 - "ASSERTION: scrollbars should not have been created" with block-in-inline, overflow:inherit, and :first-line

Status: RESOLVED FIXED

(Core :: Layout, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

Loading the testcase triggers:

###!!! ASSERTION: scrollbars should not have been created: 'result.mHorizontal != NS_STYLE_OVERFLOW_VISIBLE && result.mHorizontal != NS_STYLE_OVERFLOW_CLIP && result.mVertical != NS_STYLE_OVERFLOW_VISIBLE && result.mVertical != NS_STYLE_OVERFLOW_CLIP', file /Users/jruderman/trunk/mozilla/layout/generic/nsGfxScrollFrame.cpp, line 1433

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Same as diff -w

Comment 3

[Boris Zbarsky [:bzbarsky]]

This depends on the fix for bug 395623.  Once that lands, I'll add this testcase to the first-line reftests too.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 283802 [details] [diff] [review]
Same as diff -w

Trying roc for the review

Comment 5

[Reed Loden [:reed]]

Just a reminder to please commit this by Monday if you want to get it in before beta. Otherwise, approval1.9+ will be revoked, and you will need to re-request it after M9 if you still want to land the patch. If you would like somebody else to commit this for you, please add the "checkin-needed" keyword.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Reed, see comment 3.  This depends on a bug which was a blocker, and hence didn't have approval, and is now stuck in approval limbo.  I'd love to get this in for beta, but that bug needs to go in first.

If someone else wants to commit this and deal with any resulting fallout (like it not actually fixing this bug on its own, for example, which it doesn't), go for it.  I've only tested this patch and thought about it in the context of bug 395623 already having landed.

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 283802 [details] [diff] [review]
Same as diff -w

Resetting all approval1.9+ flags on bugs that have not been checked in by Oct 22 11:59 PM PDT.  Please re-request approval if needed.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Checked in.  layout/reftests/first-line/parent-style-1.html tests this.

Comment 9

[Boris Zbarsky [:bzbarsky]]

Also layout/reftests/first-letter/parent-style-1.html