Closed Bug 398836 Opened 17 years ago Closed 7 years ago

JS component loader doesn't follow the javascript.options.strict pref

Categories

(Core :: XPConnect, defect)

Product:
Core
Component:
XPConnect
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: peterv, Unassigned)

Details

It should set JSOPTION_STRICT at http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/js/src/xpconnect/loader/mozJSComponentLoader.cpp&rev=1.146&mark=513#508 if the javascript.options.strict pref is set to true (and dynamically set/unset it whenever the pref changes).
There are other options (zeal, warn as error, relimit) that should probably be set as well, see JSOptionChangedCallback in nsJSEnvironment.cpp.
Oh, the patch to add the zeal pref is waiting for approval in bug 308429.
Status: NEW → ASSIGNED
Status: ASSIGNED → NEW
offhand, I disagree. I'd rather we always ran components under strict (just as we always use the latest version of JavaScript - bug 381031).

nsJSEnvironment doesn't relate (it's a dom thing)
(In reply to timeless from comment #3)
> offhand, I disagree. I'd rather we always ran components under strict (just
> as we always use the latest version of JavaScript - bug 381031).

Done! in bug 1394556.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.