Closed
Bug 399360
Opened 17 years ago
Closed 17 years ago
Remove unused closure variable
Categories
(Core :: SVG, defect)
Core
SVG
Tracking
()
RESOLVED
FIXED
People
(Reporter: longsonr, Assigned: longsonr)
Details
Attachments
(1 file)
|
11.17 KB,
patch
|
tor
:
review+
tor
:
superreview+
roc
:
approval1.9+
|
Details | Diff | Splinter Review |
closure is unused since the conversion to thebes. Might as well remove it completely.
Attachment #284364 -
Flags: superreview?(tor)
Attachment #284364 -
Flags: review?(tor)
Attachment #284364 -
Flags: superreview?(tor)
Attachment #284364 -
Flags: superreview+
Attachment #284364 -
Flags: review?(tor)
Attachment #284364 -
Flags: review+
|
Assignee | |
Updated•17 years ago
|
Attachment #284364 -
Flags: approval1.9?
|
|
Assignee | |
Comment 1•17 years ago
|
||
Low risk removal of unused code.
Comment on attachment 284364 [details] [diff] [review] patch approved, but please, we'd prefer you not to spend time on things like this right now (unless they help prepare a patch for something which is a 1.9 blocker, perhaps). Obviously it's up to you what you work on, but I'll have to stop approving pure cleanup at some point.
Attachment #284364 -
Flags: approval1.9? → approval1.9+
|
||
Comment 3•17 years ago
|
||
Just a reminder to please commit this by Monday if you want to get it in before beta. Otherwise, approval1.9+ will be revoked, and you will need to re-request it after M9 if you still want to land the patch.
|
|
Assignee | |
Comment 4•17 years ago
|
||
In that case... checked in.
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•