399440 - Work offline menu has incorrect state after cancelled request to go offline in sub windows

Status: VERIFIED FIXED

(Firefox :: Menus, defect)

Description

[Dave Townsend [:mossop]]

1. Start a longish download.
2. With the downloads window focused go to file and work offline.
3. In the cancel downloads prompt opt to stay online.

I know see that in the file menu the work offline option is ticked even though the browser is not working offline.

This is also a problem in the add-ons window.

Comment 1

[Dave Townsend [:mossop]]

Attachment: patch rev 1

This also takes care of bug 399438.

Turning off autocheck from the offline menu means we only need to update the menu on window display and when offline changes. For background windows we must initialise and uninitialise the observer for this to happen properly

Comment 2

[Dave Townsend [:mossop]]

Attachment: patch rev 2

This removes the unnecessary parts. Properly initialising the BrowserOffline component fixes both issues.

Comment 3

[Dave Townsend [:mossop]]

Checking in browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.868; previous revision: 1.867
done

Comment 4

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b3pre) Gecko/2007122704 Minefield/3.0b3pre and the steps to reproduce from comment #0

-> Verified fixed