399866 - "index greater than count" warnings when adding new items to query results with any post-query filters applied

Status: RESOLVED WORKSFORME

(Firefox :: Bookmarks & History, defect)

Description

[Dietrich Ayala (:dietrich)]

Comment 1

[Dietrich Ayala (:dietrich)]

Attachment: wallpaper for a common case

this bit of code throws bogus warnings: it assumes that the index in the db will always match the index in the query result.

any number of query options (excludeItems, search terms, group_by_*) can make the db index moot.

one route might be to call nsNavHistory::GetSimpleBookmarksQueryFolder().

however, this wallpaper patch might be enough for the common case for now.

Comment 2

[(not reading, please use [e-mail] instead)]

I think we want to do something similar to what you did for bug #398295.

Can we determine the type of the item (using aItem and GetItemType(), which are already doing in nsNavHistoryFolderResultNode::OnItemAdded()), and if mOptions->ExcludeItems() is true, and we've not the type of an excluded item, we should return NS_OK; (and note, we should not call ReindexRange())

What do you think?

Comment 3

[Dietrich Ayala (:dietrich)]

note: merge the backed-out toolkit bit of bug 398295 into here, where it belongs.

Comment 5

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv

Comment 6

[Marco Bonardo [:mak]]

the workaround was practically implemented along the way and the code differs pretty much today so setting as wfm.