Closed Bug 400104 Opened 17 years ago Closed 17 years ago

Remove unused nsIFocusController::GetPopupEvent/SetPopupEvent

Categories

(Core :: DOM: Core & HTML, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9beta2

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

Details

Attachments

(1 file)

Remove unused nsIFocusController::GetPopupEvent/SetPopupEvent

History:

introduced by bug 302050
http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/content/xul/content/src/nsXULPopupListener.cpp&rev=1.136&cvsroot=/cvsroot&mark=285#285

then some more work in bug 335291

then all usage was removed by bug 279703
Attached patch Patch rev. 1Splinter Review
Attachment #285189 - Flags: superreview?(bzbarsky)
Attachment #285189 - Flags: review?(bzbarsky)
Attachment #285189 - Flags: superreview?(bzbarsky)
Attachment #285189 - Flags: superreview+
Attachment #285189 - Flags: review?(bzbarsky)
Attachment #285189 - Flags: review+
Comment on attachment 285189 [details] [diff] [review]
Patch rev. 1

Removing dead code, zero risk.
Attachment #285189 - Flags: approval1.9?
Comment on attachment 285189 [details] [diff] [review]
Patch rev. 1

a=release drivers
Attachment #285189 - Flags: approval1.9? → approval1.9+
Keywords: checkin-needed
mozilla/dom/public/base/nsIFocusController.h 	1.21
mozilla/dom/src/base/nsFocusController.cpp 	1.62
mozilla/dom/src/base/nsFocusController.h 	1.22 

-> FIXED
Status: NEW → RESOLVED
Closed: 17 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9 M10
I backed this out to see if it fixes the orange.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Relanded.
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: