400369 - List markers (bullets) positioned incorrectly for left- and center-aligned list items in RTL lists

Status: RESOLVED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Uri Bernstein]

Attachment: testcase

In an RTL list, items which are styled with "text-align:left" or "text-align:center" still have their markers right-aligned.
Furthermore, for "text-align:left", the marker position is not updated when the list's width is changed (i.e. by resizing the window).

Comment 1

[Uri Bernstein]

So, what this bug report is requesting is the "small fix" mentioned in bug 140611 comment #22.
Too bad Lina is no longer around, and it could take me quite some time to figure what this small fix actually is...

Comment 2

[Uri Bernstein]

Attachment: patch

Move the bullet left so that it's next to the rest of the line, then adjust its position together with the rest of the line (as done for LTR).

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Uri, do you want to check this in yourself or get someone else to do it for you?

Comment 4

[Uri Bernstein]

Given the restrictions on the timing of checkins (which won't necessarily match my schedule), I'd appreciate it if someone can handle this for me. Thanks.

Comment 5

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sure.

Comment 6

[Reed Loden [:reed]]

Checking in layout/generic/nsLineLayout.cpp;
/cvsroot/mozilla/layout/generic/nsLineLayout.cpp,v  <--  nsLineLayout.cpp
new revision: 3.281; previous revision: 3.280
done

Comment 7

[(no longer active)]

Mass-assigning the new rtl keyword to RTL-related (see bug 349193).