400667 - Static page titles are not localizable

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[George Fiotakis]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; el-GR; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; el-GR; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8

Allthough there is a localized string for "Credits" in all languages (footer_credits string, messages.po file), AMO uses the english word for all valid and supported locales as a page title.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.


Expected Results:  
The page title should use the localized string instead.

Comment 1

[Bruce van der Kooij]

This applies to all page views (that's appversions, credits, submissionhelp etc.) because as you can see in site/app/controllers/pages_controller.php:61 it uses a generic display function to set the title to the pagename with the first letter capitalized (so there's no localization at all).

site/app/controllers/pages_controller.php:86
$title = ucfirst($path[$count - 1]);

Maybe something like using the pagename as part of the msgid would be a good workaround (credits_pagetitle, appversions_pagetitle etc.)? Would have to update all of the po files too.

Comment 3

[Fred Wenzel [:wenzel]]

I'll fix it for the 4.0.3 milestone. Will probably make a switch statement for the page title, defaulting to the current behavior.

Comment 4

[Fred Wenzel [:wenzel]]

Attachment: Possibility to localize page titles, incl. titles for the existing pages

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 346289 [details] [diff] [review]
Possibility to localize page titles, incl. titles for the existing pages

I'd rather have the title in the .thtml files somehow but I can't think of a clean way to do it.  Them's the breaks I guess.

Comment 6

[Fred Wenzel [:wenzel]]

Committed to r19531. l10n merged out to all locales in r19533.

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Fred: ok to verify this as fixed since it was used to fix bug 462481, right?

Comment 8

[Fred Wenzel [:wenzel]]

Yes, since that bug was verifiable, this one is fixed by definition too. :)

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks Fred; verified fixed.

Comment 10

[Fred Wenzel [:wenzel]]

Has been pushed live last night.