400838 - The Search: label in Places Organizer is a button, though it should not be

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P3)

Description

[[:Aleksej]]

Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9a9pre) Gecko/2007102304 Minefield/3.0a9pre

chrome://browser/content/places/places.xul#scopebartitle

<toolbarbutton xmlns="http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul" id="scopeBarTitle" label="Search:"/>


Steps to Reproduce:

1. Go to the URL, or open Bookmarks → Organize Bookmarks
2. Type something into the search field, so a bar with mode buttons appears.
3. Hover and click the “Search” on its left.

Actual results:
It’s a button, and is acting like a button.

Expected results:
It's a label, so nothing should happen. Maybe a little tooltip, though.

Comment 1

[Dão Gottwald [:dao]]

Attachment: patch

Comment 2

[Asaf Romano (gone)]

Comment on attachment 287537 [details] [diff] [review]
patch

r=mano

Comment 3

[Reed Loden [:reed]]

Checking in browser/components/places/content/advancedSearch.inc;
/cvsroot/mozilla/browser/components/places/content/advancedSearch.inc,v  <--  advancedSearch.inc
new revision: 1.8; previous revision: 1.7
done
Checking in browser/components/places/content/places.xul;
/cvsroot/mozilla/browser/components/places/content/places.xul,v  <--  places.xul
new revision: 1.93; previous revision: 1.92
done

Comment 4

[[:Aleksej]]

Verified fixed with Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9b2pre) Gecko/2007112604 Minefield/3.0b2pre

Comment 5

[Dão Gottwald [:dao]]

This is unlikely to regress, probably doesn't need a litmus test.

Comment 6

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv