Closed
Bug 400882
Opened 17 years ago
Closed 16 years ago
Account wizard identity page needs a parent box around email textbox and postEmailText label to force ltr
Categories
(Thunderbird :: Account Manager, defect)
Thunderbird
Account Manager
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3
People
(Reporter: philor, Assigned: philor)
References
()
Details
Attachments
(1 file, 1 obsolete file)
1.42 KB,
patch
|
neil
:
review+
neil
:
superreview+
|
Details | Diff | Splinter Review |
Bug 389531 is engaged in a hopeless struggle to make the textbox where you type your gmail username and the label that says "@gmail.com" in the identity page of an ISP.rdf-driven new account wizard display properly in an rtl locale, where the proper display is [___________] @gmail.com כתובת דוא״ל: or, in the order the elements appear in the XUL, 2nd, 3rd, 1st. In the unlikely case it actually manages, it'll be through heroic and unnecessary (on the trunk) means: there should just be a parent box around the textbox and label that forces direction: ltr, since they are a single logical uri-element.
Assignee | ||
Comment 1•17 years ago
|
||
Not the "make .uri-element from xul.css valid on any element" you wanted, but on the other hand, this is a whole lot more landable (and doesn't make yet another magic class that _no_ XUL developer can use, only one that no mailnews developer can use).
Attachment #287361 -
Flags: review?(neil)
Assignee | ||
Comment 2•17 years ago
|
||
Comment on attachment 287361 [details] [diff] [review] Fix v.1 Hrm, second thoughts in bug 402637.
Attachment #287361 -
Flags: review?(neil)
Assignee | ||
Comment 3•16 years ago
|
||
You were right, expanding .uri-element to work on anything was much prettier, and only took a little over four months!
Attachment #287361 -
Attachment is obsolete: true
Attachment #308550 -
Flags: superreview?(neil)
Attachment #308550 -
Flags: review?(neil)
Updated•16 years ago
|
Attachment #308550 -
Flags: superreview?(neil)
Attachment #308550 -
Flags: superreview+
Attachment #308550 -
Flags: review?(neil)
Attachment #308550 -
Flags: review+
Assignee | ||
Comment 4•16 years ago
|
||
mailnews/base/prefs/resources/content/AccountWizard.xul 1.61
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•