401316 - Open-with downloads should not be read-only on Mac, which does not use a temp dir for them

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Ed Lee :Mardak]

Attachment: v1

I've been running into "override r--------  " when "rm <file>" from Terminal. Finder happily deletes the file though. ;)

These are downloads on my desktop that are open-with (typically pdfs opened in preview).

Note that only for os x do we keep the file around instead of deleting it by default... we should only really need to set the readonly bits if we're going to delete anyway.

Comment 1

[Damon Sicore (:damons)]

Can you elaborate on what this code does?  Maybe add a test case?

Comment 2

[Ed Lee :Mardak]

The code fixes the regression from bug 280419 that makes temporary files read-only, but it shouldn't do that for OS X where the temporary files remain on the Desktop.

biesi: Do you see any way to test this? We would need to launch an application with an exthandler-downloaded file and check the permission before the application returns (because otherwise the file would be deleted).

Comment 3

[Reed Loden [:reed]]

Any update on this? Is this still an issue? Seems like this regression would need to be fixed to make the dlmgr completely useful.

Comment 4

[Magnus Melin [:mkmelin]]

Comment on attachment 286353 [details] [diff] [review]
v1

Asking approval again, seems unclear why it was minused in the first place.

Comment 5

[Damon Sicore (:damons)]

Comment on attachment 286353 [details] [diff] [review]
v1

a1.9+=damons

Comment 6

[Ed Lee :Mardak]

Checking in uriloader/exthandler/nsExternalHelperAppService.cpp;
/cvsroot/mozilla/uriloader/exthandler/nsExternalHelperAppService.cpp,v  <--  nsExternalHelperAppService.cpp
new revision: 1.365; previous revision: 1.364
done