401449 - Smart-folders are exposed in bookmark queries

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P2)

Description

[Asaf Romano (gone)]

Attachment: patch

In the bookmarks-sidebar we do not set excludeQueries in its options (and shouldn't, we do want to expose queries in simple-folder view). As a result, searching there exposes query nodes. At least until we support "search for folders", this is hardly expected or useful.

Comment 1

[(not reading, please use [e-mail] instead)]

Comment on attachment 286473 [details] [diff] [review]
patch

r=sspitzer

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 286473 [details] [diff] [review]
patch

a=drivers for M9

Comment 3

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/nsNavHistory.cpp 1.179

Comment 4

[Marcia Knous [:marcia]]

QA could use some help with trying to verify this bug. Thanks.

Comment 5

[Dietrich Ayala (:dietrich)]

Hi Marcia, here are the verification steps:

1. open bookmarks sidebar
2. search for "starred"
3. confirm that the "recently starred pages" smart folder is *not* in the results

Comment 6

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9a9pre) Gecko/2007110204 Minefield/3.0a9pre. I verified using dietrich's steps in Comment 5 and compared to a 10-29 build which did not have the fix. Works like a charm.

Comment 7

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv