401790 - Canvas globalAlpha not applied to pattern fills

Status: RESOLVED WORKSFORME

(Core :: Graphics: Canvas2D, defect, P1)

Description

[Philip Taylor]

User-Agent:       Opera/9.24 (X11; Linux i686; U; en)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre

Canvas pattern fills are not affected by globalAlpha.

Reproducible: Always

Steps to Reproduce:
1. fillStyle = createPattern(...)
2. globalAlpha != 1
3. fill()

Actual Results:  
globalAlpha is ignored, and the pattern is drawn as if globalAlpha=1.

Expected Results:  
globalAlpha should affect the pattern.

Same results on Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a9pre) Gecko/2007103004 Minefield/3.0a9pre

Comment 1

[Ilmari Heikkinen]

Attachment: Makes canvas globalAlpha apply to pattern fill and stroke.

Comment 2

[Ilmari Heikkinen]

Attachment: Testcase for fillRect(), strokeRect(), fill() and stroke()

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Ilmari: you'll need to request review from a specific person if you don't want the review request to be lost. See http://developer.mozilla.org/en/docs/Getting_your_patch_in_the_tree . I recommend vladimir@pobox.

Comment 4

[Ilmari Heikkinen]

Gavin: Aahh, thanks! So that's what the requestee field is for (I thought it'd go to the module maintainer if left blank.) Fixed.

Comment 5

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Comment on attachment 290728 [details] [diff] [review]
Makes canvas globalAlpha apply to pattern fill and stroke.

Oy, sorry I haven't seen this yet!  Patch looks fine, though I don't understand < 0.999 -- why not just < 1.0 ?  Is the worry that we'll get a computed alpha value within epsilon of 1.0 that should really be treated as 1.0 for speed?

Comment 6

[Ilmari Heikkinen]

Yes, speed^H^H^H^H^H premature optimization. Though I guess it should be < 1.0 - (1.0 / (1 << ALPHA_BIT_DEPTH)) instead.

Comment 7

[Jeff Muizelaar [:jrmuizel]]

This seems to be fixed.