Closed
Bug 401798
Opened 17 years ago
Closed 17 years ago
Correct comma splice in malware warning description
Categories
(Toolkit :: Safe Browsing, defect)
Toolkit
Safe Browsing
Tracking
()
VERIFIED
FIXED
Firefox 3 beta1
People
(Reporter: reed, Assigned: reed)
References
()
Details
(Keywords: polish)
Attachments
(1 file)
1.18 KB,
patch
|
beltzner
:
review+
beltzner
:
ui-review+
beltzner
:
approvalM9+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
If one goes to "http://www.mozilla.com/firefox/its-an-attack.html", one will see: "The web site at www.mozilla.com has been reported as an attack site, and has been blocked based on your security preferences." The comma after "site" and before "and" should not be there.
Attachment #286766 -
Flags: review?(beltzner)
Attachment #286766 -
Flags: approvalM9?
Attachment #286766 -
Flags: approval1.9?
Comment 1•17 years ago
|
||
Comment on attachment 286766 [details] [diff] [review] patch - v1 r+uir+a=beltzner
Attachment #286766 -
Flags: ui-review+
Attachment #286766 -
Flags: review?(beltzner)
Attachment #286766 -
Flags: review+
Attachment #286766 -
Flags: approvalM9?
Attachment #286766 -
Flags: approvalM9+
Attachment #286766 -
Flags: approval1.9?
Attachment #286766 -
Flags: approval1.9+
Assignee | ||
Comment 2•17 years ago
|
||
Checking in browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties; /cvsroot/mozilla/browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties,v <-- blockedSite.properties new revision: 1.2; previous revision: 1.1 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Comment 3•17 years ago
|
||
http://owl.english.purdue.edu/owl/resource/598/02/ 1. Join the two independent clauses with one of the coordinating conjunctions (and, but, for, or, nor, so, yet), and use a comma before the connecting word. By _removing_ the very suggested comma(s), how did you fix this comma splice?
Assignee | ||
Comment 4•17 years ago
|
||
"has been blocked based on your security preferences" is not an independent clause. For it to be an independent clause, it must have a subject, which it lacks.
Comment 5•16 years ago
|
||
reed++ Verified FIXED using: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre -and- Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008012304 Minefield/3.0b3pre
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•