401844 - Thebes doesn't reflect dynamic changes in dpi

Status: RESOLVED INVALID

(Core :: Graphics, enhancement)

Description

[Brad Lassey [:blassey] (use needinfo?)]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.8) Gecko/20071008 Firefox/2.0.0.8
Build Identifier: maemo micro-browser

fixing this allows for zooming

Reproducible: Always

Steps to Reproduce:
1.
2.
3.



patch is from nokia

https://garage.maemo.org/svn/browser/mozilla/trunk/microb-engine/microb-engine/debian/patches/015_gtk_build_fix.diff

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: proposed patch from nokia

Comment 2

[Stuart Parmenter]

half the code in this patch is in files no longer in the tree and the other half looks to be total hacks.  there might be some useful parts of code in this patch but it sure isn't obvious without comments.

Comment 3

[Doug Turner (:dougt)]

maybe there is a bug, but based on the comments given, it is very hard to tell what is going on.  cc'ing timeless, maybe he can provide input here.

Comment 4

[timeless]

i didn't work on this, and i certainly wasn't going to post this.

the person who did is currently moving us back to Cairo. we have finally shipped the monstrosity that required disabling Cairo.

i hope that January (at the earliest), we can try to find the useful patches. I'm writing release notes now which means reviewing change logs. As I'm doing that, I do occasionally spot things that can be upstreamed (or at least reported). I'm quite ashamed/embarrassed by our behavior (and as I mentioned elsewhere, it really reflects very poorly on me and my principles).