402194 - Typo and inconsitency in installer's error messages

Status: VERIFIED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

As reported by Ptak82 in http://bugs.aviary.pl/show_bug.cgi?id=1280 - the translation of the "Retry" button in the error message is not consistent with the button itself. Also, due to a missing 'n' in what should be '\n', the first letter of the word 'Naciśnij' is not visible.

Screenshot: http://bugs.aviary.pl/attachment.cgi?id=924

This is fixed on trunk, but it would be nice to have it fixed in 2.0.0.10.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

Oops, the previous patch had a typo. :-)

Comment 2

[Hubert Gajewski]

Comment on attachment 287089 [details] [diff] [review]
Patch

If we do not use quotation marks at "Anuluj" and at "Przerwij" - we should not use it at "Ponów próbę"

Comment 3

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch

...with review comments addressed.

We need to use quotes around multiple-word button names to avoid ambiguity. I have nothing against quoting single-word ones as well throughout pl l10n (in fact, I think it's the right thing to do for 3.0).

It would be even better for us to use the „ and ” quotes, but I'm not sure if these are safe for NSIS, esp. on legacy Windows versions...

Comment 4

[Hubert Gajewski]

(In reply to comment #3)

> We need to use quotes around multiple-word button names to avoid ambiguity. I
> have nothing against quoting single-word ones as well throughout pl l10n (in
> fact, I think it's the right thing to do for 3.0).

Right, so we cannot change our rules at mozilla1.8 branch. I suggest do not add quotation marks now. Can you remove these signs from the patch?

Comment 5

[Marek Stępień [:marcoos, inactive]]

I suppose in this case clarity requires us to use the quotes. And for me, clarity is more important than consistency (esp. when it's consistency with something "not really right").

Comment 6

[Hubert Gajewski]

Comment on attachment 287558 [details] [diff] [review]
Patch

OK, so be it.
r=hubert

Comment 7

[Daniel Veditz [:dveditz]]

Comment on attachment 287558 [details] [diff] [review]
Patch

missed 1.8.1.10

Comment 8

[Axel Hecht [:Pike]]

Comment on attachment 287558 [details] [diff] [review]
Patch

[pl] translation fix approved for .12. Please use the fixed1.8.1.12 and verified1.8.1.12 keywords to track landing and testing.

Comment 9

[Marek Stępień [:marcoos, inactive]]

Oops, how could I forget to check this in?

fixed1.8.1.12