Closed Bug 403311 Opened 17 years ago Closed 15 years ago

/mozilla/layout/mathml/tests/ : xml pages are not W3C-valid

Categories

(Core :: MathML, defect)

Product:
Core
Component:
MathML
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla1.9.3a1

People

(Reporter: fredw, Assigned: fredw)

Details

Attachments

(1 file, 1 obsolete file)

Replace <br/> by <mspace linebreak="newline"/>
12.03 KB, patch
karlt
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; fr; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8

When you check the XML pages using the W3C validator, you get some errors. Some of them can be easily fixed. However, two types of them are due to W3C limitations :

- maxwell.xml : the declared "vec" entity is not parsed. This seems to be a bug of the W3C validator.

- mixing.xml : the XHTML elements are not accepted inside a MathML test. The doctype used is only for XHTML as the host language.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.
Assignee: nobody → rbs
Component: General → MathML
Product: Firefox → Core
QA Contact: general → ian
Attached patch Fixes some errors. (obsolete) — — Splinter Review 

    
  

        Attachment #288128 -
        Flags: review?(rbs)

    
    

    
  
Comment on attachment 288128 [details] [diff] [review]
Fixes some errors.

This is an old bug but my patch seems still appliable.

        Attachment #288128 -
        Flags: review?(mozbugz)
Status: UNCONFIRMED → NEW
Ever confirmed: true

        Attachment #288128 -
        Flags: review?(mozbugz)

    
    

    
  
Comment on attachment 288128 [details] [diff] [review]
Fixes some errors.

--- layout/mathml/tests/mixing.xml	25 Aug 2004 23:02:47 -0000	1.7
+++ layout/mathml/tests/mixing.xml	10 Nov 2007 10:03:39 -0000

 <body style="font-size: 18pt; 
       background-color: gold;
       background-image: url(resource:/res/samples/raptor.jpg);
       background-repeat: no-repeat;
       background-attachment: fixed;">
 
+<div>
+
 <h2 style="text-align: center; color: blue">
 Mixing MathML markups and other markups to get special effects</h2>

I would put the div after the h2.

-    <html:img src="chrome://communicator/skin/brand/throbber-anim.gif" />
+    <html:img src="chrome://communicator/skin/brand/throbber-anim.gif" alt="" />

I would use alt="throbber".  Here the img is not just for formatting but
important for the demonstration, so shouldn't just become invisible.

--- layout/mathml/tests/various.xml	27 Mar 2005 11:36:01 -0000	1.8
+++ layout/mathml/tests/various.xml	10 Nov 2007 10:03:39 -0000

 </mmultiscripts>
 
-<br />
-
 <!-- {3 \atop k} R {1 \atop i} {2 \atop j} -->
 <mmultiscripts>

 </mrow>
 
-<br />
-
   <mrow> 

 </mrow>
 
-<br /> 
-
-
 
 <mrow>

The <br /> here imply that the author wants a line break, and that would
certainly make this easier to read.  No newline is being generated, but I'd
rather not remove the <br /> until this is rewritten with appropriate markup
that does provide the line break.
QA Contact: ian → mathml

    
    

    
  


  
It seems that the W3C does not define inclusion of XHTML inside MathML, so I think we can't make the file mixing.xml valid for the moment:
http://www.w3.org/TR/XHTMLplusMathMLplusSVG/#bugs

I replaced the <br/>'s inside MathML by <mspace/>'s. However, it looks like Mozilla does not support the attribute "linebreak" (anyway the <br/>'s currently do not make any likebreak). See bug 380266

        Attachment #288128 -
        Attachment is obsolete: true

        Attachment #288128 -
        Flags: review?(rbs)

    
  

        Attachment #398104 -
        Flags: review?(mozbugz)

        Attachment #398104 -
        Flags: review?(mozbugz) → review+

    
    

    
  
Comment on attachment 398104 [details] [diff] [review]
Replace <br/> by <mspace linebreak="newline"/>

I don't actually understand why entities declared in http://www.w3.org/TR/MathML2/dtd/xhtml-math11-f.dtd can't be used be used in other entity declarations, but these changes look good anyway, thanks.

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/ddcadd576143
Assignee: rbs → fred.wang
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.3a1

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: