403462 - clarify localization note in blockedSite.properties

Status: RESOLVED FIXED

(Toolkit :: Safe Browsing, defect)

Description

[Axel Hecht [:Pike]]

The localization note in blockedSite.properties for phishing.learnMoreLink seems to be a tad misleading, see bug 403246.

It'd be nice if we could clarify that it's only affecting the markup of the link, not the anchor text.

Maybe "please leave the HTML markup for ... as is." instead of the "... text".

Abdulkadir, would that have helped?

Comment 1

[Kadir Topal [:atopal]]

Yes, or "please leave the HTML tag for ... as is." would have definitly helped.

Comment 2

[Johnathan Nightingale [:johnath]]

Attachment: Fix localization note

Doh.  Is this text better?

Comment 3

[Axel Hecht [:Pike]]

Comment on attachment 288309 [details] [diff] [review]
Fix localization note

yes, thanks. r=me

Comment 4

[Johnathan Nightingale [:johnath]]

Comment on attachment 288309 [details] [diff] [review]
Fix localization note

Is this something I can land? It makes localizers' life easier, and no code is touched, just a properties file?

Comment 5

[Reed Loden [:reed]]

It's a comment change... just land it once the tree reopens.

Comment 6

[Johnathan Nightingale [:johnath]]

Checking in browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/safebrowsing/blockedSite.properties,v  <--  blockedSite.properties
new revision: 1.3; previous revision: 1.2