403678 - Removal of GC thing callback

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P4)

Description

[Igor Bukanov]

With the bug 401687 fixed the GC thing callback infrastructure added to JS GC to support the cycle collector is no longer necessary and can be safely removed. It would be nice to do it before FF3 is released and GC thing callback becomes a part of public API.

Comment 1

[Igor Bukanov]

Attachment: v1

The patch removes gcThingCallback and related code.

Comment 2

[Mike Schroepfer]

Blocking with low priority so we get a clean public bug

Comment 3

[Peter Van der Beken [:peterv]]

Comment on attachment 288554 [details] [diff] [review]
v1

>Index: js/src/jsgc.c
>===================================================================

>@@ -2086,34 +2081,22 @@ gc_lock_traversal(JSDHashTable *table, J

>+    if (!IS_GC_MARKING_TRACER(trc)) {
>+        for (n = lhe->count - 1; n != 0; --n)
>+            JS_CALL_TRACER(trc, thing, traceKind, "locked object");
>     }

Note that since the cycle collector doesn't refcount it doesn't rely on this anymore either. Unless you want to keep it for other users feel free to drop it too.

Comment 4

[Igor Bukanov]

Attachment: v2

The new version removes that "lock count transfer to the tracer".

Comment 5

[Brendan Eich [:brendan]]

Comment on attachment 288677 [details] [diff] [review]
v2

Yay! Thanks.

/be

Comment 6

[Igor Bukanov]

I checked in the patch from comment 4 to CVS trunk:

http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&branch=HEAD&cvsroot=%2Fcvsroot&date=explicit&mindate=1195469790&maxdate=1195469824&who=igor%mir2.org