404425 - Add Exception Dialogs looks broken

Status: RESOLVED FIXED

(Core Graveyard :: Security: UI, defect)

Description

[Kai Engert (:KaiE:)]

I'm attaching a screenshot. This is what the add exception dialog looks like on linux trunk.

The bold heading has weird indenting.

The boxes around the sections are gone.

Comment 1

[Kai Engert (:KaiE:)]

Attachment: screen shot

Comment 2

[Johnathan Nightingale [:johnath]]

Attachment: Remove whitespace around entity

Sigh...

The text is styled as moz-pre-wrap, but the XUL assumes that it's okay to leave whitespace around the entity.  This wasn't spotted when the code first landed because the CSS rule was broken.  When the fix to the CSS landed, it "regressed" this, but that just never should have been there.  My bad.  :(

Comment 3

[Kai Engert (:KaiE:)]

Comment on attachment 289510 [details] [diff] [review]
Remove whitespace around entity

Thanks for the fix, r=kengert

Nit: Would it make sense to avoid very long lines by moving the ">" to the next line? Like this:

  <description id="warningSupplemental"
               style="font-weight: bold; white-space: -moz-pre-wrap;"
  >&exceptionMgr.supplementalWarning;</description>

(or similar).

Would it make sense to add a <!--comment--> explaining that whitespace must be avoided between the tags?

Comment 4

[Johnathan Nightingale [:johnath]]

Attachment: Nits addressed

Requesting approval.  This is absolutely not a blocker, but it also looks stupid (see attachment 289414 [details]) and broken in its current form.  There is zero semantic change here, just whitespace around a DTD entity.  Under normal circumstances I don't think I'd even request a=, but I know we are clamping down.

Comment 5

[Johnathan Nightingale [:johnath]]

Checking in security/manager/pki/resources/content/exceptionDialog.xul;
/cvsroot/mozilla/security/manager/pki/resources/content/exceptionDialog.xul,v  <--  exceptionDialog.xul
new revision: 1.6; previous revision: 1.5
done