404480 - Unable to Close Tabs when "Open Tabs Relative" code is active in userChrome.js

Status: RESOLVED DUPLICATE of bug 404499

(Core :: JavaScript Engine, defect)

Description

[ronin.achilles]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111923 Minefield/3.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b2pre) Gecko/2007111923 Minefield/3.0b2pre

I use userChrome.js extension and have included the following code for "Tabs Open Relative" functionality (so basically open New Tabs or Links next to active tab):

/*::::::::::::::::::::::: Open Tabs Relative ::::::::::::::::::::::::*/

(function() {
getBrowser().__uc_addedTabs = 0;

eval("gBrowser.addTab = " + gBrowser.addTab.toString().replace(/\{/, "$& var __oldTabPos = this.mCurrentTab._tPos;").replace(/return /, "if (!blank) this.moveTabTo(t, __oldTabPos + 1 + this.__uc_addedTabs++); $&"));

eval("gBrowser.moveTabTo = " + gBrowser.moveTabTo.toString().replace(/{/, "$& if (aTab == this.mCurrentTab) this.__uc_addedTabs = 0;"));

eval("nsBrowserAccess.prototype.openURI = " + nsBrowserAccess.prototype.openURI.toString().replace(/(loadOneTab\()"about:blank"/, '$1"data:text/html,"'));

gBrowser.mTabContainer.addEventListener("select", function() { gBrowser.__uc_addedTabs = 0; }, false);
})();


This was working perfectly well till yesterday. I downloaded the hourly after the landing of "New Left Pane for Places Organizer"; I believe a few other bugs were also landed between the previous nightly and this particular hourly.

On this hourly, if the code mentioned above is included in userChrome.js, I am not able to close tabs.

I see the following error in error console:

Error: uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIWebProgress.removeProgressListener]"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/tabbrowser.xml :: removeTab :: line 1393"  data: no]

Not sure what went wrong.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[ronin.achilles]

Blocking Bug #387746. Am not sure if the regression is due to that bug, but seems most likely.

Comment 2

[ronin.achilles]

Just looked for the regression range. Looks like it is Bug #398609 and build is: 20071119_0916_firefox-3.0b2pre.en-US.win32

Comment 3

[Igor Bukanov]

Could you check on which line of the code the exception is thrown? 

Comment 4

[ronin.achilles]

(In reply to comment #3)
> Could you check on which line of the code the exception is thrown? 
> 

I looked into tabbrowser.xml and given that the error is occuring near line 1392/1393 (from Error Console), the problems seems to be somewhere in the follwing code (this code is part of the removeTab method):

            // Remove the tab's filter and progress listener.
            const filter = this.mTabFilters[index];
            var oldBrowser = this.getBrowserAtIndex(index);
            oldBrowser.webProgress.removeProgressListener(filter);
            filter.removeProgressListener(this.mTabListeners[index]);
            this.mTabFilters.splice(index, 1);
            this.mTabListeners.splice(index, 1);

Comment 5

[ronin.achilles]

Now this problem occurs intermittently (starting 11/20 nightly). Will watch for a few builds and report back if the problem persists.

Comment 6

[ronin.achilles]

Since Build 20071119_0916_firefox-3.0b2pre.en-US.win32 (when Bug #398609 was checked in), another thing that broke is opening of links from external applications. But there are a lot of interdependencies as follows:

- In 1119_0916 build, if the code mentioned above is removed from userChrome.js, then links from external applications open correctly.
- As of today, 'Tab History' extension got busted (https://addons.mozilla.org/en-US/firefox/addon/1859). If you disable the Tab History extension, links open fine again.

Am not sure what are the dependencies here, but all of them basically seem to have originated from Bug #398609. In addition, today's thread shows that a lot of other extensions have also been busted. (http://forums.mozillazine.org/viewtopic.php?t=605117). Its possible that it could have been caused due to some additional check-ins, but surely a lot of them originated on 11/19.

Comment 7

[Igor Bukanov]

I suspect that the regressions are covered by bug 404499 where the patch is waiting for a review/approval.

Comment 8

[Mike Beltzner [:beltzner, not reading bugmail]]

Igor: do you think this blocks? I'm not compelled by the specific use case reflected in comment 0, but if it's implying that there's a deeper problem in JS, we should probably block on it.

Comment 9

[Igor Bukanov]

(In reply to comment #8)
> Igor: do you think this blocks? 

The bug 404499 definitely should block. If addressing that would not help this one, I will consider blocking this one.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

--> Core::Javascript Engine

Comment 11

[Mike Beltzner [:beltzner, not reading bugmail]]

transferring nomination; possibly to be fixed by bug 404499, but I think we should block on it just in case it isn't.

Comment 12

[ronin.achilles]

Post Bug #404499 landing, in the latest hourly, I *think* most of the problems I was facing with extensions and Javascript have been resolved. Keeping my fingers crossed. If things go well for a day or two, we can close this Bug.

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

K, minusing for now, renom if it isn't fixed.

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

Er, whoops, that was wrong of me. PLUSsing for now, please mark fixed if it turns out to be fixed. :)

Comment 15

[ronin.achilles]

Marking Fixed for now.