Closed
Bug 405153
Opened 17 years ago
Closed 17 years ago
add a patcher config for trunk
Categories
(Release Engineering :: General, defect, P2)
Release Engineering
General
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: bhearsum, Assigned: bhearsum)
References
Details
Attachments
(1 file, 2 obsolete files)
Attached is a patcher config file for trunk. The completemarurl's for all the alphas are invalid, but that should be OK as we are only going to offer partials for 3.0b2 from 3.0b1. I'm still new to patcher config so I expect problems with this version :).
Attachment #289961 -
Flags: review?(nrthomas)
Assignee | ||
Updated•17 years ago
|
Priority: -- → P2
Assignee | ||
Comment 1•17 years ago
|
||
Attachment #289961 -
Attachment is obsolete: true
Attachment #290567 -
Flags: review?(nrthomas)
Attachment #289961 -
Flags: review?(nrthomas)
Updated•17 years ago
|
Attachment #290567 -
Attachment mime type: application/octet-stream → text/plain
Comment 2•17 years ago
|
||
Comment on attachment 290567 [details] close <complete> block properly, run through Config::General to clean-up A funny thing happened on the way to the patch ... only older versions of Config::General alphabetize. :-S Comments inline. ><app> > <Firefox> > <current-update> > to 3.0b2 > testchannel betatest releasetest We'll just need betatest until we get to 3.0rc1. It's harmless, but potentially confusing, to create them in the meantime. > <rc> > betatest 1 > beta 1 > </rc> Pretty sure we won't be pushing out beta builds on the beta channel, that seems waaaay to confusing, so you can remove this block. > from 3.0b1 > channel beta release As above, no need for release yet. > details http://www.mozilla.com/%locale%/firefox/%version%/releasenotes/ > <partial> > beta-url http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/3.0b2-candidates/rc1/firefox-3.0b1-3.0b2.%locale%.%platform%.partial.mar beta-url can go, then we'll end up with beta going do download.m.o and betatest going to stage.m.o > past-update 3.0a8 3.0a9 betatest beta > past-update 3.0a9 3.0b1 betatest beta We didn't do an a9, so please collapse these lines into one. > </current-update> Would be great to chose some logical ordering for <current-update> if Config::General isn't going to munge it. Maybe: from to testchannels channels details <partial> <complete> > <release> > <3.0a4> I'd like to give this in reverse-release order, eg: <3.0b1>...<3.0a8>...<3.0a7>. Then subsequent patches will be have all the changes close together. > <platforms> > win32 2007042705 > linux-i686 2007042705 > mac 2007042705 Consistent ordering of platform lines please. > </platforms> > version 3.0a4 We have extension-version defined in the 1.8 config. Could you check the patcher2.pl code to see if it falls back to version if it's not defined. We had this strange thing with 2.0b1 being 1.4 for extension version, but haven't done that sort of thing since. > completemarurl http://stage.mozilla.org/pub/mozilla.org/firefox/releases/granparadiso/alpha1/%platform%/%locale%/firefox-3.0a4.complete.mar You've got .../granparadiso/alpha1/%platform%/.. in all the release blocks. We also use "schema 1" in each release block, so that the update snippets have setting=value pairs. > <3.0a9> > <platforms> > win32 2007091216 > linux-i686 2007091211 > mac 2006091211 > </platforms> > version 3.0a9 > completemarurl http://stage.mozilla.org/pub/mozilla.org/firefox/releases/granparadiso/alpha1/%platform%/%locale%/firefox-3.0a9.complete.mar > locales en-US > </3.0a9> Dunno where this guy came from. > <3.0b1> > <platforms> > win32 2007110904 > linux-i686 2007110903 > mac 2007110903 > </platforms> > version 3.0b1 > completemarurl http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/3.0b1-candidates/rc3/firefox-3.0b1.%locale%.%platform%.complete.mar > locales en-US > </3.0b1> Missing locales here, and you'll need an exceptions block.
Attachment #290567 -
Flags: review?(nrthomas) → review-
Assignee | ||
Comment 3•17 years ago
|
||
> Would be great to chose some logical ordering for <current-update> if > Config::General isn't going to munge it. AFAICT Config::General messes up my attempts at ordering things. Release blocks end up going from 3.0a4 -> 3.0a7 -> 3.0a1, etc. I didn't spend any time making this nice since it won't persist :(. > We have extension-version defined in the 1.8 config. Could you check the > patcher2.pl code to see if it falls back to version if it's not defined. We had > this strange thing with 2.0b1 being 1.4 for extension version, but haven't done > that sort of thing since. There was very little reference to the extension version in patcher2.pl but from what I could gather, a missing extension-version is not handled. Either way, it can't hurt to have the extension-version in the release blocks, so I added it. > You've got .../granparadiso/alpha1/%platform%/.. in all the release blocks. Fixed. > We also use "schema 1" in each release block, so that the update snippets > have > setting=value > pairs. Added >> <3.0b1> >> <platforms> >> win32 2007110904 >> linux-i686 2007110903 >> mac 2007110903 >> </platforms> >> version 3.0b1 >> completemarurl http://stage.mozilla.org/pub/mozilla.org/firefox/nightly/3.0b1-candidates/rc3/firefox-3.0b1.%locale%.%platform%.complete.mar >> locales en-US >> </3.0b1> > Missing locales here, and you'll need an exceptions block. Fixed.
Attachment #290567 -
Attachment is obsolete: true
Attachment #291229 -
Flags: review?
Assignee | ||
Updated•17 years ago
|
Attachment #291229 -
Flags: review? → review?(rhelmer)
Updated•17 years ago
|
Attachment #291229 -
Flags: review?(rhelmer) → review+
Assignee | ||
Comment 4•17 years ago
|
||
Checked in as part of bug 394033
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Updated•11 years ago
|
Product: mozilla.org → Release Engineering
You need to log in
before you can comment on or make changes to this bug.
Description
•