405163 - New toolbar icons in tango style

Status: RESOLVED FIXED

(Firefox :: Shell Integration, defect)

Description

[Michael Monreal [:micmon]]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.8) Gecko/20071022 Ubuntu/7.10 (gutsy) Firefox/2.0.0.8
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112304 Minefield/3.0b2pre

This bug is actually part of bug 381206 (Tango Style theme for better Linux UI integration).

As a first part of the tango theme, here we have the new images containing the icons needed for small and large toolbars. 

We will use the same image for normal, active and hover, so the bitmaps only contain normal and disabled states. Note that most toolbar icons are taken from GTK now, so this new image map only includes icons for downloads, bookmarks, history, tab-new and window-new.

The tar also contains a CSS to override and test the new icons. No complete patch, as I am currently unable to build Firefox from source.

Reproducible: Always

Comment 1

[Michael Monreal [:micmon]]

Attachment: Toolbar icons

Comment 2

[Dão Gottwald [:dao]]

Are you able to produce a patch for the CSS changes?

Comment 3

[Michael Monreal [:micmon]]

As I wrote, I haven't build firefox for a while and I'm unfamiliar with the source. 

I would probably manage to do it (as it is only replacing a few image references and coordinates) but I would need some help getting started (fetching right branch from CVS, where to find "gnomestripe"...)

Comment 4

[Ryan Flint [:rflint] (ping via IRC for reviews)]

New CSS and images checked in with a1.9=mconnor.

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

mozilla/browser/themes/gnomestripe/browser/browser.css 	1.136
mozilla/browser/themes/gnomestripe/browser/Toolbar-small.png 	1.7
mozilla/browser/themes/gnomestripe/browser/Toolbar.png 	1.7 

Comment 6

[Ryan VanderMeulen [:RyanVM]]

Michael, for future reference, detailed build instructions can be found here:
http://developer.mozilla.org/en/docs/Build_Documentation

As for the location of gnomestripe, once you've got a copy of the source, it's in mozilla/browser/themes/gnomestripe/browser

Comment 7

[Michael Monreal [:micmon]]

The checkin caused the back and forward buttons in Places Organizer to become invalid (the image no longer includes nav icons.

To fix this, the solution is to use GTK stock icons there, too. See Bug 404530, I prepared the needed CSS changes.

Comment 8

[Joe Smith]

Attachment: Places Organizer: Back/Forward Buttons Invisible

Comment 9

[Joe Smith]

Attachment: Places Organizer: Back/Forward Buttons Visible

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b2pre) Gecko/2007112619 Minefield/3.0b2pre ID:2007112619

The Back/Forward history buttons started out invisible ( https://bugzilla.mozilla.org/attachment.cgi?id=290351 ). After proceeding to view a folder, the back button appeared. Both icons appear when you have items present before/after in history.

This works out, but shouldn't the icons just be grayed out as opposed to completely invisible? It seems a bit awkward for the user to have the buttons just appear.

Comment 10

[Joe Smith]

Or I could be terribly mistaken, and those icons aren't even forward/back icons. Thanks Aleksej.

Comment 11

[Michael Monreal [:micmon]]

Joe, have a look what I posted right before you in comment #7. This should be fixed in trunk (see bug 401279).

Comment 12

[Joe Smith]

Yep, now WFM. Looks great, Michael :)