40529 - Some error returns in PR_GetIPNodeByName don't properly clean up

Status: RESOLVED FIXED

(NSPR :: NSPR, defect, P3)

Description

[Wan-Teh Chang]

In prnetdb.c, PR_GetIPNodeByName, some error returns
in the #if defined(_PR_INET6) && defined(_PR_HAVE_GETHOSTBYNAME2)
block towards the end of the function (which appends
the IPv4 addresses to the end of the addr list) don't
properly clean up.

Specifically, at the two places where Alloc() fails,
the function just returns PR_FAILURE.  It does not
set the error code, and it does not unlock the dns
lock.  This can be fixed by moving that block of code
to a different function and having PR_GetIPNodeByName
call this new function.

Another problem is that we don't need to execute
that piece of code if the CopyHostent() call fails.

Comment 1

[Wan-Teh Chang]

Attachment: Proposed patch.

Comment 2

[Wan-Teh Chang]

Checked in the fix on the main trunk.
/cvsroot/mozilla/nsprpub/pr/src/misc/prnetdb.c, revision 3.16