405389 - Passwords reappear after being deleted, when using the search

Status: VERIFIED FIXED

(Toolkit :: Password Manager, defect, P2)

Description

[Hobbsee]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b1) Gecko/2007111419 GranParadiso/3.0b1
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b1) Gecko/2007111419 GranParadiso/3.0b1

Based on https://bugzilla.mozilla.org/show_bug.cgi?id=315416

If i remove a few entries from the password manager, then hit "show passwords", the deleted entries show up.  This only happens after using the search first, and then deleting the passwords.

Steps to reproduce:

open the p/w manager
type in a search query.  
pick one of the entries, hit delete.  
it vanishes.  
hit show passwords.  
it comes back.  
either clear the search bar then, and the offending username/password vanishes, or hit "hide passwords", then clear the search bar, and the offending username/password vanishes.

When using signon.debug javascript.options.showInConsole options, nothing abnormal is shown.  It's not profile / extension / etc related.

Reproducible: Always

Comment 1

[Justin Dolske [:Dolske]]

DeleteSignon() in toolkit/components/passwordmgr/content/passwordManager.js looks suspicious to me. The list it's deleting from is specified by:

|signonsTreeView._filterSet.length ? signonsTreeView._filterSet : signons|

Comment 2

[(no longer active)]

Regression from bug 327048.  Taking over...

Comment 3

[(no longer active)]

Attachment: Patch (v1)

The code at <http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/toolkit/components/passwordmgr/content/passwordManager.js&rev=1.18&mark=121#119> can't be touched, because of the way that the |DeleteSelectedItemFromTree()| function works.

The problem is caused by the fact that if passwords are deleted from a filtered view, the deletions are not made in the original (non-filtered) |signons| table, so when an action on that original table is performed next (such as, clicking Show Passwords) the deleted entries re-appear.

The proposed solution is to reload the |signons| table in |FinalizeSignonDeletions()| if the deletions are performed in a filtered view, so that the two tables stay in sync.

This patch implements the mentioned solution.  It's been tested, and the test case in the comment 0 cannot be reproduced on a trunk build with this patch.

Comment 4

[Reed Loden [:reed]]

Checking in toolkit/components/passwordmgr/content/passwordManager.js;
/cvsroot/mozilla/toolkit/components/passwordmgr/content/passwordManager.js,v  <--  passwordManager.js
new revision: 1.19; previous revision: 1.18
done

Comment 5

[Marcia Knous [:marcia]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008042504 Minefield/3.0pre. https://litmus.mozilla.org/show_test.cgi?id=5294 added to litmus.