Closed
Bug 405479
Opened 17 years ago
Closed 17 years ago
test from bug 377539 has a potential race condition
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: dcamp, Assigned: dcamp)
References
Details
Attachments
(1 file, 1 obsolete file)
1.26 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
The test case from bug 377539 relies on the child iframe being loaded before the script finishes executing. The attached patch waits for the iframe's onload event. This doesn't seem to cause a problem normally, but the patch in bug 394525 was able to trigger it.
Attachment #290257 -
Flags: review?(bzbarsky)
Updated•17 years ago
|
Assignee: nobody → dcamp
OS: Mac OS X → All
Hardware: PC → All
Version: unspecified → Trunk
Comment 1•17 years ago
|
||
Comment on attachment 290257 [details] [diff] [review] wait for the child iframe to load You need some waitForExplicitFinish/finish() stuff here so the test doesn't end before doChecks runs. But good catch on the problem!
Attachment #290257 -
Flags: review?(bzbarsky) → review-
Assignee | ||
Comment 2•17 years ago
|
||
duh, new version.
Attachment #290257 -
Attachment is obsolete: true
Attachment #290302 -
Flags: review?(bzbarsky)
Comment 3•17 years ago
|
||
Comment on attachment 290302 [details] [diff] [review] with waitForExplicitFinish() Excellent. Thank you again for catching this!
Attachment #290302 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 4•17 years ago
|
||
cvs commit: Examining . Checking in test_bug377539.html; /cvsroot/mozilla/dom/tests/mochitest/bugs/test_bug377539.html,v <-- test_bug377539.html new revision: 1.2; previous revision: 1.1 done
Status: NEW → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•