405704 - Make the default packager format bzip2 instead of gzip for Camino 2.0

Status: RESOLVED FIXED

(Camino Graveyard :: General, defect)

Description

[Simon Howes]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9b2pre) Gecko/2007112700 Camino/2.0a1pre (like Firefox/3.0b2pre)
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en; rv:1.9b2pre) Gecko/2007112700 Camino/2.0a1pre (like Firefox/3.0b2pre)

We could save bandwidth by changing the default compression used to package up Camino 2.0.  All users will be running 10.4+ so I see no reason not to.

Reproducible: Always

Steps to Reproduce:
1.
2.
3.

Comment 1

[Chris Lawson (gone)]

mento, any thoughts?

Comment 2

[Mark Mentovai]

It would be a pretty simple fix to pkg-dmg to make it treat UDBZ as it currently treats UDZO.  We'd also want some packager.mk magic to control the format.  Shouldn't be a big deal.  I'd support it.

Comment 3

[Mark Mentovai]

Attachment: Support "--format UDBZ" in pkg-dmg

Karsten, this shouldn't conflict in any meaningful way with your patch.

Comment 4

[Mark Mentovai]

+     '-imagekey', ($format eq 'UDBZ' ? 'bzip2-level=9' : 'gzip-level=9'),

-imagekey bzip2-level=9 is only functional when writing disk images on Leopard.  On Tiger, the key is ignored, and 1 (smallest block size, least compression) is always used.

Comment 5

[Karsten Düsterloh]

Comment on attachment 291469 [details] [diff] [review]
Support "--format UDBZ" in pkg-dmg

>-    if(command($gConfig{'cmd_hdiutil'}, 'convert', '-format', 'UDZO',
>-     '-imagekey', 'zlib-level=9', 
>+    if(command($gConfig{'cmd_hdiutil'}, 'convert', '-format', $format,
>+     '-imagekey', ($format eq 'UDBZ' ? 'bzip2-level=9' : 'gzip-level=9'),

FWIW, I don't run 10.5, just 10.4.11.
For me, gzip-level doesn't do anything, regardless whether its value is 1 or 9, so I suppose it's a typo: either  in the patch (you meant zlib-level?) or in your followup comment ("On Tiger, the key [bzip2-level] is ignored" actually talks about the gzip-level key)...

Some numbers for my SM debug builds (PPC):

UDZO zlib-level=9  => 19614664
UDZO gzib-level=9  => 23580698
UDZO zlib-level=1  => 23580698
UDZO gzib-level=1  => 23580698

I'm not sure if bzip2-level works for me, because the numbers differed only slightly, but changed in each additional run. :-/
This would of course support your comment #4...

UDBZ bzip2-level=9 => 17251970
UDBZ bzip2-level=1 => 17252035

Comment 6

[Mark Mentovai]

Attachment: Support "--format UDBZ" in pkg-dmg, v2

You're right, good catch.  I've moved that back to zlib-level (typo!) and added a comment discussing bzip2-level.  ("file" handily tells you the bzip block size.)

Comment 7

[Damon Sicore (:damons)]

Comment on attachment 291903 [details] [diff] [review]
Support "--format UDBZ" in pkg-dmg, v2

a=endgame drivers.

Comment 8

[Mark Mentovai]

Attachment: Use --format UDBZ for Camino

Comment 9

[Mark Mentovai]

Checked in on the trunk.

Comment 10

[Mark Mentovai]

Watching the cb-xserve01 tinderbox-builds, with no changes other than the default packager format switching from UDZO to UDBZ, Camino.dmg went from 14,913kB to 13,725kB.  -1,188kB 8%.