406297 - Assertion "Possibly stale float cache here!" fires incorrectly

Status: RESOLVED FIXED

(Core :: Layout: Block and Inline, defect)

Description

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: obvious patch

The assertion was added in bug 406137:
  NS_ASSERTION(!line->HasFloats(), "Possibly stale float cache here!");

This fires a lot. The problem is, it fires for lines that aren't dirty, which is wrong, because the float caches for non-dirty line will be just fine. Obvious/trivial patch attached.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 290966 [details] [diff] [review]
obvious patch

r+sr+a1.9=dbaron

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in