Closed Bug 406972 Opened 17 years ago Closed 17 years ago

Try server styling tweaks

Categories

(Release Engineering :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: johnath, Assigned: johnath)

Details

Attachments

(3 files, 2 obsolete files)

Attached patch Patch v1 (obsolete) — Splinter Review
I spent a couple minutes tweaking the tryserver front end and figured I might as well make a patch out of it.  Changes include:

 - Added a favicon so I can find that tab - used "wand" from FAMFAMFAM's silk set.  Credited in source.
 - Changed page title to help awesomebar retrieval
 - Added intro paragraph with linkage to wiki page and tinderbox, as well as noting the 30 day expiry time (since I always forget and have to look it up)
 - Emphasized the patch field more, since it's the only required one.  Removed the "required" text beside it since the emphasis probably makes that apparent, and if not, it's caught by error checking anyhow
 - Changed a couple of field labels to make it slightly clearer that they are only-if-you-feel-like-it.
 - Misc. styling tweaks, some visible, some not so
Attachment #291653 - Flags: review?(bhearsum)
Comment on attachment 291653 [details] [diff] [review]
Patch v1

Minor nit: Let's use the static 'http://tinderbox.mozilla.org/MozillaTry' for the TINDERBOX_URL, rather than the dynamic version.

Other than that, I like. r=bhearsum with that change.
Attachment #291653 - Flags: review?(bhearsum) → review+
Attached patch Patch as checked in (obsolete) — Splinter Review
Assignee: nobody → johnath
Attachment #291653 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attached image background graphic
Checking in sendchange-ui.pm;
/cvsroot/mozilla/webtools/buildbot-try/sendchange-ui.pm,v  <--  sendchange-ui.pm
new revision: 1.2; previous revision: 1.1
done
RCS file: /cvsroot/mozilla/webtools/buildbot-try/background.jpg,v
done
Checking in background.jpg;
/cvsroot/mozilla/webtools/buildbot-try/background.jpg,v  <--  background.jpg
initial revision: 1.1
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
$BUILDBOT_URL is used as the link to the public status page, ie. Tinderbox. No need to have a second variable set to the same thing ;).

I should've caught this in review...I've changed it to a saner default so this doesn't happen again.
Attachment #292072 - Attachment is obsolete: true
Attachment #292391 - Flags: review?
Attachment #292391 - Flags: review? → review?(johnath)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Comment on attachment 292391 [details] [diff] [review]
remove TINDERBOX_URL; use BUILDBOT_URL in it's place

Makes sense to me!
Attachment #292391 - Flags: review?(johnath) → review+
Checking in sendchange-ui.pm;
/cvsroot/mozilla/webtools/buildbot-try/sendchange-ui.pm,v  <--  sendchange-ui.pm
new revision: 1.3; previous revision: 1.2
done
The try server now has purdyness!
https://build.mozilla.org/sendchange.cgi
Status: REOPENED → RESOLVED
Closed: 17 years ago17 years ago
Resolution: --- → FIXED
Moving try server bugs to the new component.
Component: Build & Release → Try Server
Product: mozilla.org → Webtools
QA Contact: build → try-server
Component: Try Server → Release Engineering
Product: Webtools → mozilla.org
QA Contact: try-server → release
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: