407009 - "ASSERTION: Shouldn't be forcing a hidden scrollbar to show!" with xul tree in <select>

Status: VERIFIED FIXED

(Core :: Layout, defect, P2)

Description

[Jesse Ruderman]

Attachment: testcase

###!!! ASSERTION: Shouldn't be forcing a hidden scrollbar to show!: '!aForce', file /Users/jruderman/trunk/mozilla/layout/generic/nsGfxScrollFrame.cpp, line 334

I'm pretty sure this is a regression from within the last few days.  Maybe it's a regression from bug 375304?

I think this can lead to a crash [@ nsHTMLScrollFrame::ReflowScrolledFrame].

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

almost certainly bug 375304, yes

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: trivial patch

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 291742 [details] [diff] [review]
trivial patch

r+sr=dbaron

Comment 4

[Brian Polidoro]

(In reply to comment #0)
> I think this can lead to a crash [@ nsHTMLScrollFrame::ReflowScrolledFrame].
> 
You don't say. ;) Bug 407047

Comment 6

[Mike Schroepfer]

Roc set a priority if you need to...

Comment 7

[Carsten Book [:Tomcat]]

Attachment: result on linux

i created a debug build with this patch included to test bug 407015 and Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9b2pre) Gecko/2007120610 Minefield/3.0b2pre does not report a assertion on the testcase.

I have attached a image how the testcase looks now. Not sure if this is the expected result.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

It's good enough given the testcase.

Comment 9

[Robert O'Callahan (:roc) (email my personal email if necessary)]

checked in

Comment 10

[Jesse Ruderman]

Crashtest checked in.

Comment 11

[Carsten Book [:Tomcat]]

verified fixed using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008050621 Firefox/3.0pre -no assertion on testcase