Closed Bug 40731 Opened 24 years ago Closed 24 years ago

ECMA ed. 3 Object.prototype.hasOwnProperty sub-optimal for indexes

Categories

(Core :: JavaScript Engine, defect, P3)

Product:
Core
Component:
JavaScript Engine
Type:
defect

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: brendan, Assigned: brendan)

Details

(Keywords: js1.5)

Attachments

(2 files)

proposed fix
3.12 KB, patch
Details | Diff | Splinter Review
better patch, no warning (unused atom removed)
3.30 KB, patch
Details | Diff | Splinter Review 
tag-able integer property ids, that is.  Patch coming up.

/be
Status: NEW → ASSIGNED
Keywords: js1.5
Target Milestone: --- → M16
Attached patch proposed fix — — Splinter Review 

    
    

    
  
Duh, not busted, just sub-optimal: property lookup must equate '2' to 2, e.g., 
so the patch is just a minor optimization to avoid making a string atom when a 
tagged-int property id will do.

/be
Summary: ECMA ed. 3 Object.prototype.hasOwnProperty busted for indexes → ECMA ed. 3 Object.prototype.hasOwnProperty sub-optimal for indexes

    
    

    
  
Looking for r=.

/be

    
    

    
  
Roger, looking for r= and shaver jumped on a plane.  Thanks,

/be

    
    

    
  
Fix checked in, I just know that shaver will approve (rogerl is on vacation till 
the 12th).

/be
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: