407476 - make a copy of nsAccessibilityUtils

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[alexander :surkov (:asurkov)]

make a copy of files

original files:
accessible\src\base\nsAccessibilityUtils.h
accessible\src\base\nsAccessibilityUtils.cpp

destination file:
accessible\src\base\nsAccUtils.h
accessible\src\base\nsAccUtils.cpp

Original files won't be needed after coping. Should I put the patch now to use new files that will be checked in it simultaneously with file coping? Or is it preferable to file another bug where I remove old files and will use new files?

Comment 1

[alexander :surkov (:asurkov)]

We need to copy these files because nsAccessiblityUtils class has been renamed to nsAccUtils in bug 386922.

Comment 2

[alexander :surkov (:asurkov)]

Attachment: use new files

use new files patch

Comment 3

[Reed Loden [:reed]]

(In reply to comment #0)
> Original files won't be needed after coping. Should I put the patch now to use
> new files that will be checked in it simultaneously with file coping? Or is it
> preferable to file another bug where I remove old files and will use new files?

Since you already attached a patch to this bug, I would move this bug back to an a11y-related component, attach a cvscopy file there and get review on it, then file antoher cvs copy bug referencing the reviewed cvscopy file.

Comment 4

[alexander :surkov (:asurkov)]

How should cvscopy file look like and who should review it, accessibility peer?

Comment 5

[Reed Loden [:reed]]

(In reply to comment #4)
> How should cvscopy file look like and who should review it, accessibility peer?

See attachment 290895 [details] for an example, and yes, an a11y peer/owner should review it.

Comment 6

[Reed Loden [:reed]]

Basically, the file consists of lines of:
path/to/old/file path/to/new/file

Comment 7

[alexander :surkov (:asurkov)]

Attachment: cvs copy

Comment 8

[Reed Loden [:reed]]

Comment on attachment 292207 [details]
cvs copy

This is wrong. Need to use '/' instead of '\', and while you can start at accessible/, it is preferred that the cvscopy file start at mozilla/.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: cvs copy

sorry. new cvscopy file.

Comment 10

[Reed Loden [:reed]]

Comment on attachment 292208 [details]
cvs copy

This is better, but I doubt you meant to copy the same file twice. :)

Comment 11

[alexander :surkov (:asurkov)]

Attachment: cvs copy

(In reply to comment #10)
> (From update of attachment 292208 [details])
> This is better, but I doubt you meant to copy the same file twice. :)
> 

thank you, I need to be more careful

Comment 12

[Aaron Leventhal]

Why I are you doing this right now though? It conflicts with a big patch I have in bug 398910.

Comment 13

[alexander :surkov (:asurkov)]

(In reply to comment #12)
> Why I are you doing this right now though? It conflicts with a big patch I have
> in bug 398910.
> 

good question
1) I was aroung when introduced hypertext utils file, I remembered I wanted to rename it.
2) Previously it took a long time to copy files therefore I decided to start it now
3) I missed you patch banaly :)

Comment 14

[Mike Schroepfer]

Comment on attachment 292201 [details] [diff] [review]
use new files

Until you guys resolve comment 12

Comment 15

[Mike Schroepfer]

Comment on attachment 292209 [details]
cvs copy

Until you guys resolve comment 12

Comment 16

[alexander :surkov (:asurkov)]

fixed in bug 459973