407656 - Canceling a scanning download should make it done

Status: VERIFIED WONTFIX

(Toolkit :: Downloads API, defect)

Description

[Ed Lee :Mardak]

Instead of making a scanning download canceled when canceling, we should just let it finish as if there was no scan.

Bug 407655 introduces this into the UI, but there's potentially other calls to CancelDownload.

Comment 1

[Ed Lee :Mardak]

Attachment: v1

I actually haven't tested this.. I'll try getting a windows build.

Note for the UI, I changed it to delete only if the download is actually canceled by the back-end. Hopefully the SetState FINISHED notification gets to the UI to update "state" so that checking it works..

Comment 2

[Shawn Wilsher :sdwilsh]

<beltzner> well, I think we've pretty much decided that cancel sucks
<beltzner> I think we need to make sure to look for bad hanging cases, fix the restart case, and then see if we need to pref this off

WONTFIX

We'll need a bug to fix the case where we crash so we can set it right, and perhaps a bug to timeout if we don't get feedback from the virus scanner (since we can't find in the api where it says it times out.  Perhaps I was seeing things when I read that?).

Please file follow-up at least for the first issue.