409287 - Report broken website tango icon

Status: RESOLVED WONTFIX

(Other Applications Graveyard :: Reporter, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Tango icon (16, 24) + CSS

The "report broken website" button is the only button on the toolbar that does not yet use the tango style on linux. This is the tango version in 16x16 and 24x24, including the disabled states. Needs a proper patch for integration.

Comment 1

[Michael Ventnor]

Attachment: Patch

Comment 2

[[e-mail]]

FYI this stops Reporter from being a true extension
(i.e. building the same chrome for all platforms).

Comment 3

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #2)
> FYI this stops Reporter from being a true extension
> (i.e. building the same chrome for all platforms).

Indeed. Can we use a platform specific package here instead of the build-time ifdef?

Comment 4

[Michael Ventnor]

Attachment: Patch 2

Comment 5

[Ryan Flint [:rflint] (ping via IRC for reviews)]

Comment on attachment 298386 [details] [diff] [review]
Patch 2

>Index: browser/themes/gnomestripe/browser/browser.css
>+#reporterMenuButton[disabled="true"] {
>+  -moz-image-region: rect(24px 24px 48px 0px) !important;
>+}

>+toolbar[iconsize="small"] #reporterMenuButton[disabled="true"] {
>+  -moz-image-region: rect(16px 16px 32px 0px) !important;
>+}

Reporter's an overlay, so you're going to lose the battle of the cascade to: http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/extensions/reporter/resources/skin/classic/reporter/browserOverlay.css&rev=1.3&mark=21,42#20

>Index: browser/themes/gnomestripe/browser/jar.mn
Right? (wink, wink, nudge ;))

Looking at the icon, I'd say it's a fairly suitable replacement for all three platforms and would only require creating a hover state and overriding that in gnomestripe - Robert should probably weigh in on that though.

Comment 6

[Alex Faaborg [:faaborg] (Firefox UX)]

Adding this to the icon inventory, we will try to get it on all platforms.  As usual Team Penguin is in the lead :)

Comment 7

[Alex Faaborg [:faaborg] (Firefox UX)]

To match os x and the two windows themes, we would like the tango report site button added to the far right of /browser/themes/gnomestripe/browser/Toolbar.png

Comment 8

[Reed Loden [:reed]]

(In reply to comment #7)
> To match os x and the two windows themes, we would like the tango report site
> button added to the far right of
> /browser/themes/gnomestripe/browser/Toolbar.png

Are you sure that's the best way to go with fixing this issue? Seems very odd to be sticking the "Report Site" icon in Toolbar.png when reporter itself is an extension.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

We aren't got to take away the report site icon, so the extension isn't dependent on the theme, but we also thought it made the most sense for each themes toolbar icons to be grouped together.

Comment 10

[Alex Faaborg [:faaborg] (Firefox UX)]

Gavin: can you confirm that this is the right thing to do, since reporter is an extension.

Comment 11

[Michael Monreal [:micmon]]

Attachment: Updated toolbar images

Sorry for the delay. Here are the updated toolbar images featuring the bug icons (small and normal size)

Comment 12

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #10)
> Gavin: can you confirm that this is the right thing to do, since reporter is an
> extension.

It's an extension, but there's no problem with adding our own icon and overriding the extension-shipped one in our CSS.

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

Setting this bug to wontfix since we decided to remove these icons from the toolbar customization palette