409419 - https://uk.add-ons.mozilla.com/uk/firefox/ does not redirect correctly

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Localization, defect)

Description

[Pascal Chevrel:pascalc (PTO until April 26)]

Some of the link redirects we use work for some languages, some don't :

https://uk.add-ons.mozilla.com/uk/firefox/
 -> redirects to http accept-lang choice

https://de.add-ons.mozilla.com/de/firefox/
 -> redirects to https://addons.mozilla.org/de/firefox/

Comment 1

[Wil Clouser [:clouserw]]

I seem to recall these were hardcoded redirects and since uk is newer than de it's probably not in the list.  I'm assigning to oremj to check if this is true.  If it is, I can give a list of all languages AMO supports to add to the list.

Comment 2

[Jeremy Orem [:oremj]]

Yep, uk isn't in there.  The whole list would be nice.

Comment 3

[Wil Clouser [:clouserw]]

    'cs'
    'da'
    'de'
    'en-US'
    'el'
    'es-ES'
    'eu'
    'fi'
    'fr'
    'it'
    'ja'
    'ko'
    'mn'
    'nl'
    'pl'
    'ro'
    'ru'
    'sk'
    'sq'
    'uk'

Comment 4

[Jeremy Orem [:oremj]]

-    RewriteRule ^/(cs|da|de|en-US|es-ES|fr|it|ja|ko|pl|ro|ru|sk|sq)/(.+?)/(\d.+?)/(.*)$ https://addons.mozilla.org/$1/$2/$4 [R,L]
-    RewriteRule ^/(cs|da|de|en-US|es-ES|fr|it|ja|ko|pl|ro|ru|sk|sq)(/.*)?$ https://addons.mozilla.org/$1$2 [R,L]
+    RewriteRule ^/(cs|da|de|en-US|el|es-ES|eu|fi|fr|it|ja|ko|mn|nl|pl|ro|ru|sk|sq|uk)/(.+?)/(\d.+?)/(.*)$ https://addons.mozilla.org/$1/$2/$4 [R,L]
+    RewriteRule ^/(cs|da|de|en-US|el|es-ES|eu|fi|fr|it|ja|ko|mn|nl|pl|ro|ru|sk|sq|uk)(/.*)?$ https://addons.mozilla.org/$1$2 [R,L]

Pushed above changes live.