Closed Bug 409682 Opened 17 years ago Closed 17 years ago

Whine should not add headers for queries with 0 bugs

Categories

(Bugzilla :: Whining, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Bugzilla 3.2

People

(Reporter: Callek, Assigned: Callek)

Details

Attachments

(1 file, 1 obsolete file)

Attached patch simple fix (obsolete) — Splinter Review
In a whine's e-mail, if there are no actual returned bugs, the whine is never sent. However if in a single whine with hundreds of queries, but only one bug, all the headers of each and every other query are still listed in the e-mail.

This is just unnecessary bloat.
Attachment #294466 - Flags: review?(LpSolit)
Status: NEW → ASSIGNED
Assignee: whining → bugspam.Callek
Status: ASSIGNED → NEW
Comment on attachment 294466 [details] [diff] [review]
simple fix

>+        unless ($thisquery->{'onemailperbug'} ||
>+                !@{$thisquery->{'bugs'}}) {

To make the logic easier to understand you should rather write:

 if (!$thisquery->{'onemailperbug'} && @{$thisquery->{'bugs'}}) {...}


r=LpSolit with this comment addressed.
Attachment #294466 - Flags: review?(LpSolit) → review+
Status: NEW → ASSIGNED
Flags: approval+
Target Milestone: --- → Bugzilla 3.2
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.36; previous revision: 1.35
done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Attached patch checked in patchSplinter Review
Attachment #294466 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: