Closed
Bug 410258
Opened 17 years ago
Closed 17 years ago
EXTRA_PP_COMPONENTS and EXTRA_PP_JS_MODULES fail if the target directory does not already exist
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla1.9beta3
People
(Reporter: mossop, Assigned: mossop)
Details
Attachments
(1 file)
1.14 KB,
patch
|
ted
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
Piping to the non-existant directory causes the build to fail. This patch just ensures the directory exists first.
Attachment #294899 -
Flags: review?(ted.mielczarek)
Updated•17 years ago
|
Attachment #294899 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 1•17 years ago
|
||
Comment on attachment 294899 [details] [diff] [review] create directories first Looking for approval for this minor build config change. Shouldn't affect any currently building apps but makes life a little easier for new small apps using our build system that may only have one component/module.
Attachment #294899 -
Flags: approval1.9?
Updated•17 years ago
|
Assignee: nobody → dtownsend
Assignee | ||
Updated•17 years ago
|
Whiteboard: [has patch]
Assignee | ||
Updated•17 years ago
|
Status: NEW → ASSIGNED
Comment 2•17 years ago
|
||
Comment on attachment 294899 [details] [diff] [review] create directories first a=beltzner for 1.9
Attachment #294899 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 3•17 years ago
|
||
Checking in config/rules.mk; /cvsroot/mozilla/config/rules.mk,v <-- rules.mk new revision: 3.581; previous revision: 3.580 done
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Whiteboard: [has patch]
Assignee | ||
Updated•16 years ago
|
Target Milestone: --- → mozilla1.9 M11
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•