Closed Bug 410479 Opened 17 years ago Closed 17 years ago

replace nsSimpleUInt32Array with nsTArray<DWORD>

Categories

(MailNews Core :: Import, defect)

Product:
MailNews Core
Component:
Import
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: neil, Assigned: neil)

Details

Attachments

(2 files, 1 obsolete file)

-w version
3.25 KB, patch
Details | Diff | Splinter Review
Fixed patch
3.91 KB, patch
Bienvenu
: review+
Bienvenu
: superreview+
Details | Diff | Splinter Review 
MapiMessage rolls its own array class, which we can replace wth nsTArray.
Attached patch Proposed patch (obsolete) — — Splinter Review 

        Attachment #295085 -
        Flags: superreview?(bienvenu)

        Attachment #295085 -
        Flags: review?(bienvenu)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        -w version
        — 
          — Splinter Review
      

    


  

    
    

    
  

      
      
      
      

        Attached patch
          
          
        Fixed patch
        — 
          — Splinter Review
      

    


  
Whoops, after compiling I thought "hey, I forgot to remove the class decl" but forgot to remove the impl too...
Assignee: nobody → neil

        Attachment #295085 -
        Attachment is obsolete: true
Status: NEW → ASSIGNED

        Attachment #295205 -
        Flags: superreview?(bienvenu)

        Attachment #295205 -
        Flags: review?(bienvenu)

        Attachment #295085 -
        Flags: superreview?(bienvenu)

        Attachment #295085 -
        Flags: review?(bienvenu)

    
    

    
  
See also bug 258018 where there is already an patch to do this for MapiMessage.


    
    

    
  
(In reply to comment #4)
>See also bug 258018 where there is already an patch to do this for MapiMessage.
Yes, but this patch was first, and the other patch doesn't belong there anyway.

    
    

    
  
Comment on attachment 295205 [details] [diff] [review]
Fixed patch

thx, Neil.

        Attachment #295205 -
        Flags: superreview?(bienvenu)

        Attachment #295205 -
        Flags: superreview+

        Attachment #295205 -
        Flags: review?(bienvenu)

        Attachment #295205 -
        Flags: review+

    
    

    
  
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Product: Core → MailNews Core

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: