411010 - Duplicate access keys in Views > Sort in Places Organizer

Status: RESOLVED FIXED

(Firefox :: Menus, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Gavin: this is the next one in my duplicate access keys series.  :-)

The Views > Sort menu in Places Organizer (a.k.a Library) contains two entries with access key (A): "Sort by Added" and "A > Z Sort Order".  Since (A) makes a lot of sense as the access key for "A > Z Sort Order" (and contrasts the access key for "_Z_ > A Sort Order" nicely), we'll keep it, and change the access key for "Sort by Added" to (e).

This patch implements this change.

Comment 1

[(no longer active)]

Hmmm, now that I think, Firefox :: Menus seems to be a better place for this bug...

Comment 2

[(no longer active)]

Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

This needs some acceleration because the l10n freeze is near.

Comment 3

[Asaf Romano (gone)]

Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

We could sure do it after l10n freeze, but r=me anyway :p

You don't need ui-r here.

Comment 4

[(no longer active)]

Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

Seeking approval on this.  This is a polish issue and the change is pretty low-risk.

Comment 5

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 295607 [details] [diff] [review]
Patch (v1)

a=beltzner for 1.9

Comment 6

[Reed Loden [:reed]]

Checking in browser/locales/en-US/chrome/browser/places/places.properties;
/cvsroot/mozilla/browser/locales/en-US/chrome/browser/places/places.properties,v  <--  places.properties
new revision: 1.35; previous revision: 1.34
done