411172 - del key does not remove files from the download manager anymore

Status: VERIFIED FIXED

(Toolkit :: Downloads API, defect)

Description

[Peter van der Woude [:Peter6]]

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9b3pre) Gecko/2008010708 Minefield/3.0b3pre ID:2008010708

repro:
open FF
open DM
select a file and hit the [del] key on your keyboard

result:
nada

expected:
the file to be removed from the list

nothing in the errorconsole

this regressed today

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Nor on Mac, neither -> OS: All

Comment 2

[Peter van der Woude [:Peter6]]

regressionwindow:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1199664600&maxdate=1199665799

-> Bug 392293 ?

Comment 3

[Elmar Ludwig]

Attachment: patch v1

Like so? This patch fixes the problem for me.

Comment 4

[Shawn Wilsher :sdwilsh]

Oh hey, I missed two.  I regret to inform you that we'll need a browser test for this as well though.

Comment 5

[Elmar Ludwig]

Well, the bug isn't assigned to me, is it... ;-)

What kind of test do you mean? Litmus?

Comment 6

[Shawn Wilsher :sdwilsh]

no - an automated browser test - Like I have in attachment 295657 [details] [diff] [review].

Comment 7

[Shawn Wilsher :sdwilsh]

Comment on attachment 295831 [details] [diff] [review]
patch v1

r=sdwilsh

Test being attached momentarily

Comment 8

[Shawn Wilsher :sdwilsh]

Attachment: patch with test

same patch as v1, but with the test

Comment 9

[Shawn Wilsher :sdwilsh]

Thanks for the patch!

Checking in toolkit/mozapps/downloads/content/downloads.xul;
new revision: 1.44; previous revision: 1.43

Checking in toolkit/mozapps/downloads/tests/browser/Makefile.in;
new revision: 1.4; previous revision: 1.3
Checking in toolkit/mozapps/downloads/tests/browser/browser_bug_411172.js;
initial revision: 1.1

Stephen - you can now remove the litmus test for this since we have an automated one for it!

Comment 10

[Shawn Wilsher :sdwilsh]

I backed out the test for this since it was failing on Linux.  I'm guessing that one of the keys isn't working for removing downloads, and I'm not sure why...

Checking in toolkit/mozapps/downloads/tests/browser/Makefile.in;
new revision: 1.5; previous revision: 1.4

Comment 11

[Shawn Wilsher :sdwilsh]

Attachment: v2 test

As Ryan pointed out on irc last night - only mac uses VK_DOM_BACK_SPACE.  Oops...

Comment 12

[Elmar Ludwig]

I should have noticed that as well, but I hadn't looked at the test in detail...

Comment 13

[Shawn Wilsher :sdwilsh]

All better :)

Checking in toolkit/mozapps/downloads/tests/browser/Makefile.in;
new revision: 1.6; previous revision: 1.5
Checking in toolkit/mozapps/downloads/tests/browser/browser_bug_411172.js;
new revision: 1.2; previous revision: 1.1
Checking in toolkit/mozapps/downloads/tests/browser/browser_bug_411172_mac.js;
initial revision: 1.1

Comment 14

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b3pre) Gecko/2008011104 Minefield/3.0b3pre

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b3pre) Gecko/2008011104 Minefield/3.0b3pre

and

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b3pre) Gecko/2008011105 Minefield/3.0b3pre

Comment 15

[Stephen Donner [:stephend] Not actively reading bugmail]

https://litmus.mozilla.org/show_test.cgi?id=4553

in-litmus+

Comment 16

[Stephen Donner [:stephend] Not actively reading bugmail]

In addition to automating the delete-and-then-select-the-next-download testcase above, we should have ones for the following:

* when the user is anywhere but the absolute bottom of the DM list, we should keep advancing/selecting downloads until we come to the bottom of the list, at which point we should start moving upwards.
* we should also test--if possible--that starting to delete from the bottom of the DM list moves upwards