411728 - Update Polish Wikipedia search plugin to support suggestions

Status: VERIFIED FIXED

(Mozilla Localizations :: pl / Polish, defect)

Description

[Marek Stępień [:marcoos, inactive]]

The search plugin Wikipedia offers on wikipedia.org implements the MozSearch suggestions feature.

Let's update the Wikipedia plugin in the Polish localization of Firefox 3 to do the same.

Comment 1

[Marek Stępień [:marcoos, inactive]]

Attachment: Add suggestions to Wikipedia's plugin

Comment 2

[Marek Stępień [:marcoos, inactive]]

Attachment: Add suggestions to Wikipedia's plugin

...but don't drop the sourceid=Mozilla part ;)

Comment 3

[:Gavin Sharp [email: [e-mail]]]

The OpenSearch namespace changes really aren't necessary, the search service ignores namespaces entirely.

Comment 4

[Marek Stępień [:marcoos, inactive]]

Ok, I'll drop the namespace. I just did what the official Wikipedia plugin does.

Comment 5

[Marek Stępień [:marcoos, inactive]]

Attachment: Add suggestions to Wikipedia's plugin

Dropping the OpenSearch namespace, bringing back <SearchForm />.

Comment 6

[Marek Stępień [:marcoos, inactive]]

Attachment: Add suggestions to Wikipedia's plugin

Use <Param>s instead of query string full of HTML entities

Comment 7

[Axel Hecht [:Pike]]

Comment on attachment 296416 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

r=me with two nits, see below

>Index: pl/browser/searchplugins/wikipedia-pl.xml
<...>
>+<Url type="text/html" method="GET" template="http://pl.wikipedia.org/w/index.php">
>+    <Param name="title" value="Specjalna:Szukaj" />

Make this template="http://pl.wikipedia.org/wiki/Specjalna:Szukaj"
and drop the title param.

>+    <Param name="search" value="{searchTerms}" />
>+    <Param name="sourceid" value="Mozilla-search" />
>+</Url>
<SearchForm>http://pl.wikipedia.org/wiki/Specjalna:Search</SearchForm>
> </SearchPlugin>
>\ No newline at end of file

Add a trailing newline, too?

Please check this in with a check-in comment referencing this bug and my review.

Comment 8

[Marek Stępień [:marcoos, inactive]]

Checking in wikipedia-pl.xml;
/l10n/l10n/pl/browser/searchplugins/wikipedia-pl.xml,v  <--  wikipedia-pl.xml
new revision: 1.3; previous revision: 1.2
done

Comment 9

[Marek Stępień [:marcoos, inactive]]

Can I fix this also on the 1.8 branch for Firefox 2.0.0.x?

Comment 10

[Marek Stępień [:marcoos, inactive]]

Comment on attachment 296416 [details] [diff] [review]
Add suggestions to Wikipedia's plugin

This patch also applies cleanly to the 1.8 branch.

Comment 11

[Marek Stępień [:marcoos, inactive]]

Attachment: Patch for the 1.8 branch

This is the patch as checked in to trunk (with all the stuff from comment 7 applied), ready for checking in to 1.8, if that gets approval.

Comment 12

[Axel Hecht [:Pike]]

Comment on attachment 296558 [details] [diff] [review]
Patch for the 1.8 branch

[pl] approval for landing an update to the wikipedia search plugin on the branch.

Please use the fixed1.8.1.12 and verified.... keywords to track landing and testing.

Comment 13

[Marek Stępień [:marcoos, inactive]]

Checking in wikipedia-pl.xml;
/l10n/l10n/pl/browser/searchplugins/wikipedia-pl.xml,v  <--  wikipedia-pl.xml
new revision: 1.1.2.2; previous revision: 1.1.2.1
done

Comment 14

[Hubert Gajewski]

Verified (Fx 3.0 beta 3 & Fx 2.0.0.12)