412059 - "Impersonate this user" link on editusers.cgi uses incorrect filter

Status: RESOLVED FIXED

(Bugzilla :: User Accounts, defect)

Description

[Reed Loden [:reed]]

Attachment: patch - v1

Noticed this while I was working on another bug.

          <a href="relogin.cgi?action=prepare-sudo&amp;target_login=
          [%- otheruser.login FILTER html %]">Impersonate this user</a>

That "html" filter should be "url_quote" instead, or else e-mail addresses that have characters like '+' in them will not be escaped properly.

Comment 1

[Frédéric Buclin]

Comment on attachment 296681 [details] [diff] [review]
patch - v1

Yes, this fixes the problem. r=LpSolit

Comment 2

[Frédéric Buclin]

This bug also exists in Bugzilla 2.22. Let's take it on this branch too.

Comment 3

[Reed Loden [:reed]]

tip

Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v  <--  userdata.html.tmpl
new revision: 1.12; previous revision: 1.11
done


BUGZILLA-3_0-BRANCH

Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v  <--  userdata.html.tmpl
new revision: 1.8.2.2; previous revision: 1.8.2.1
done


BUGZILLA-2_22-BRANCH

Checking in template/en/default/admin/users/userdata.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/admin/users/userdata.html.tmpl,v  <--  userdata.html.tmpl
new revision: 1.5.2.1; previous revision: 1.5
done