Closed
Bug 412490
Opened 16 years ago
Closed 16 years ago
Migrate debugQA preferences to the new pref window.
Categories
(SeaMonkey :: Preferences, defect)
SeaMonkey
Preferences
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: standard8, Assigned: standard8)
References
Details
Attachments
(2 files)
17.33 KB,
patch
|
neil
:
review+
|
Details | Diff | Splinter Review |
21.22 KB,
patch
|
Details | Diff | Splinter Review |
Part of the ongoing effort, this one is the debugQA extension's preferences. The patch does the necessary and also fixes a couple of errors I saw in the old pref window (wrong preferences being toggled), and drops some unneeded grid code.
Attachment #297229 -
Flags: review?(neil)
Assignee | ||
Comment 1•16 years ago
|
||
Attachment #297230 -
Flags: review?(neil)
Comment 2•16 years ago
|
||
from past talks with roc, we don't expect XBL-Forms to continue to work, we can probably drop that pref with this migration.
Comment 3•16 years ago
|
||
Comment on attachment 297229 [details] [diff] [review] The fix (diff -w) >+ <preference id="print.use_global_printsettings" >+ name="print.use_global_printsettings" type="bool"/> >+ <preference id="extensions.dss.enabled" name="extensions.dss.enabled" >+ type="bool"/> Might as well put the name on the next line, slightly less inconsistent. >- <row align="center"> >+ <hbox> Missing align. r=me with this fixed. >+ <preference id="nglayout.debug.crossing_event_dumping" >+ name="nglayout.debug.crossing_event_dumping" >+ type="bool"/> Might as well put the type on the same line, slightly less inconsistent.
Attachment #297229 -
Flags: review?(neil) → review+
Updated•16 years ago
|
Attachment #297230 -
Flags: review?(neil)
Assignee | ||
Comment 4•16 years ago
|
||
Patch checked in with comments address, I also dropped the XBL-Forms pref at the same time (KaiRo also thought it was ok). Fixed.
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•