412685 - Update of reporting page with a new selection widget

Status: NEW

(Bugzilla :: Reporting/Charting, enhancement, P1)

Description

[Guy Pyrzak]

Attachment: Redesign of reports widget.

This bug is to add a new report selection widget as well as combine existing Table/Graphical reports into one (if that makes sense)

Comment 1

[Max Kanat-Alexander]

Comment on attachment 297424 [details]
Redesign of reports widget.

Yeah, looks great to me. What happens when there's no JS?

Comment 2

[Max Kanat-Alexander]

I suspect this is more of a 4.0-timeframe thing.

Comment 3

[Frédéric Buclin]

Comment on attachment 297424 [details]
Redesign of reports widget.

I like it too (if someone cares).

Comment 4

[Max Kanat-Alexander]

Is there any chance that we could ever get this really awesome patch? :-) It's already all written at NASA, right?

Comment 5

[Alex Eiser]

The problem is that to support non javascript users is hard.

Comment 6

[Max Kanat-Alexander]

(In reply to comment #5)
> The problem is that to support non javascript users is hard.

  Then don't. :-) Or I'll provide the suggestions when the patch is posted. It's 2009, we can require JS for things like this.

Comment 7

[Guy Pyrzak]

Ok, I'll do this next (after my reviews are done)! The change would involve mostly YUI stuff so it should degrade nicely.

Comment 8

[Frédéric Buclin]

We no longer accept new features for Bugzilla 3.6. Retargetting to 3.8.

Comment 9

[Max Kanat-Alexander]

Halloo. Any progress on this?

Comment 10

[Max Kanat-Alexander]

  I would really love to see this for 4.2. I think this is the #1 UI improvement I'd like to see for 4.2. :-)

Comment 11

[Guy Pyrzak]

Attachment: WIP

Here is the work in progress, I'll attach the 2 sprites as well.

Comment 12

[Guy Pyrzak]

Attachment: preview sprite

Comment 13

[Guy Pyrzak]

Attachment: style button sprite

Comment 14

[Guy Pyrzak]

blank.png is just a blank png

Comment 15

[Max Kanat-Alexander]

Comment on attachment 489037 [details] [diff] [review]
WIP

Coooooool!!! A few comments on a general overview basis without looking at the code in detail or having applied the patch:

Since there seem to be a lot of globals in chart_widget.js, it seems like it should all be an object instead, kind of like how userAutocomplete is, and so on. That would also prevent having so many globals, and so on.

There's enough chart widget CSS for it to be its own file, instead of being in search_form.css.

Comment 16

[Guy Pyrzak]

Yup, was gonna make it its own object. Unfortunately I need to keep some of the code in the template for localization purposes. Good to hear about the chart css being able to be its own file. Hopefully i'll have something real soon.

Comment 17

[Guy Pyrzak]

Attachment: Screenshot 1

Comment 18

[Guy Pyrzak]

Attachment: Screenshot 2

Comment 19

[Frédéric Buclin]

We are going to branch for Bugzilla 4.4 next week and this bug is too invasive or too risky to be accepted for 4.4 at this point. The target milestone is set to 5.0 which is our next major release.

I ask the assignee to reassign the bug to the default assignee if you don't plan to work on this bug in the near future, to make it clearer which bugs should be fixed by someone else on time for 5.0.

Comment 20

[Sagar Vaghela]

Attachment: adbms.txt

new data